Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sage-monorepo): keep only the root workspace as pnpm workspace #2777

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix(sage-monorepo): keep only the root workspace as pnpm workspace #2777

merged 3 commits into from
Aug 28, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Aug 27, 2024 •
edited
Loading

Changelog

  • Exclude API clients for Angular from pnpm workspaces

Preview

Remaining workspaces:

$ pnpm m ls --depth -1 --json
[
  {
    "name": "sage-monorepo",
    "version": "0.0.0",
    "path": "/workspaces/sage-monorepo",
    "private": true
  }
]

@tschaffter tschaffter self-assigned this Aug 27, 2024
@tschaffter tschaffter marked this pull request as ready for review August 27, 2024 23:28
@tschaffter tschaffter changed the title fix(sage-monorepo): prevent the creation of node_modules for API client for Angular fix(sage-monorepo): keep only the root workspace as pnpm workspace Aug 27, 2024
@tschaffter tschaffter merged commit f8f2e7d into Sage-Bionetworks:main Aug 28, 2024
9 of 10 checks passed
@tschaffter tschaffter deleted the sage-monorepo/prevent-api-client-angular-node-modules branch August 28, 2024 01:26
@tschaffter tschaffter mentioned this pull request Aug 28, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tschaffter