Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sage-monorepo): externalize the config and ruleset used by the OpenAPI validator for OpenChallenges #2818

Merged
merged 5 commits into from
Sep 17, 2024
Merged

feat(sage-monorepo): externalize the config and ruleset used by the OpenAPI validator for OpenChallenges #2818

merged 5 commits into from
Sep 17, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Sep 16, 2024 •
edited
Loading

Description

Externalize the config and ruleset used by the OpenAPI validator for OpenChallenges as a first step towards applying the same linting config to multiple projects developed in this monorepo.

Future work

  • Configure the following projects to use this common configuration:
    • schematic-api-description
    • agora-api-description
    • model-ad-api-description

Changelog

  • Move the config and ruleset used by the OpenAPI validator for OpenChallenges
  • Parallelize the linting of OC's multiple API description files

@tschaffter tschaffter self-assigned this Sep 16, 2024
@tschaffter tschaffter marked this pull request as ready for review September 16, 2024 20:46
@tschaffter tschaffter requested a review from linglp September 16, 2024 20:46
@tschaffter tschaffter changed the title feat(sage-monorepo): externalize the OpenAPI validation config and ruleset outside of openchallenges-api-description feat(sage-monorepo): externalize the config and ruleset used by the OpenAPI validator for OpenChallenges Sep 16, 2024
rrchai
rrchai approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@rrchai rrchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tschaffter tschaffter added this pull request to the merge queue Sep 17, 2024
Merged via the queue into Sage-Bionetworks:main with commit a93fedd Sep 17, 2024
8 of 9 checks passed
@tschaffter tschaffter deleted the sage-monorepo/centralize-oas-ruleset branch September 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrchai rrchai rrchai approved these changes

@sagely1 sagely1 Awaiting requested review from sagely1

@andrewelamb andrewelamb Awaiting requested review from andrewelamb

@vpchung vpchung Awaiting requested review from vpchung

@linglp linglp Awaiting requested review from linglp

Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschaffter @rrchai