Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sage-monorepo): lint staged Dockerfiles with Hadolint (ARCH-278) #2829

Merged
merged 4 commits into from
Sep 17, 2024
Merged

feat(sage-monorepo): lint staged Dockerfiles with Hadolint (ARCH-278) #2829

merged 4 commits into from
Sep 17, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Sep 17, 2024 •
edited
Loading

Closes https://sagebionetworks.jira.com/browse/ARCH-278

Changelog

  • Configure lint-staged to lint staged Dockerfiles with Hadolint
  • Remove a rule exception from the dev container Dockerfile
  • Update a comment Hadolint config file

Preview

image

@tschaffter tschaffter self-assigned this Sep 17, 2024
@tschaffter tschaffter marked this pull request as ready for review September 17, 2024 21:00
@tschaffter tschaffter requested a review from sagely1 September 17, 2024 21:15
sagely1
sagely1 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@sagely1 sagely1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a Dockerfile by adding an ENV variable without value and attempting a commit correctly flagged the linting error.

@tschaffter tschaffter added this pull request to the merge queue Sep 17, 2024
Merged via the queue into Sage-Bionetworks:main with commit 96393a2 Sep 17, 2024
11 checks passed
@tschaffter tschaffter deleted the sage-monorepo/lint-staged-docker branch September 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagely1 sagely1 sagely1 approved these changes

Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschaffter @sagely1