Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sage-monorepo): update Nx and its dependencies (ARCH-282) #2842

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Sep 22, 2024

Closes https://sagebionetworks.jira.com/browse/ARCH-282

Changelog

  • Update Nx to the latest version
  • Update Angular to the latest version (v18.2.5)
  • Add @chromatic-com/storybook (added by the migration script)

Notes

Tests

✔️Validate OpenChallenges

$ openchallenges-build-images
$ nx serve-detach openchallenges-apex
  • Manual review of the web app

✔️Validate Agora

$ agora-build-images
$ nx serve-detach agora-apex
  • Manual review of the web app

Cc: @sagely1

@tschaffter
Copy link
Member Author

Storybook 8 Migration Summary

Upgrade Storybook packages

The following command was ran to upgrade the Storybook packages:

npx storybook@latest upgrade

The Storybook automigration scripts were ran

The following commands ran successfully and your Storybook configuration was successfully migrated to the latest version 7:

  • pnpm dlx storybook@latest automigrate --config-dir libs/results-visualization-framework/ui/.storybook

  • pnpm dlx storybook@latest automigrate --config-dir libs/shared/typescript/charts-angular/.storybook

Please make sure to check the results yourself and make sure that everything is working as expected.

Also, we may have missed something. Please make sure to check the logs of the Storybook CLI commands that were run, and look for
the ❌ Failed trying to evaluate message or ❌ The migration failed to update message. This will indicate if a command was
unsuccessful, and will help you run the migration again, manually.

Next steps

You can make sure everything is working as expected by trying
to build or serve your Storybook as you normally would.

npx nx build-storybook project-name
npx nx storybook project-name

Please read the Storybook 8.0.0 release article and the
official Storybook 8.0.0 migration guide
for more information.

@tschaffter tschaffter marked this pull request as ready for review September 22, 2024 20:27
@tschaffter tschaffter merged commit 46e260c into Sage-Bionetworks:main Sep 22, 2024
20 of 21 checks passed
@tschaffter tschaffter deleted the sage-monorepo/update-nx branch September 22, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant