-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): add Mariadb Connection and Load the EDAM Concepts #2898
base: main
Are you sure you want to change the base?
feat(openchallenges): add Mariadb Connection and Load the EDAM Concepts #2898
Conversation
…connector@2.2.9 to install mysql
From the first comment:
However this PR only aims to connect to the DB, not to load the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are Python dependencies missing from the project (see below). Try to remove the folder .venv
in the project folder and run nx prepare openchallenges-edam-etl
to use a fresh virtual environment.
Serve
$ nx serve openchallenges-edam-etl
> nx run openchallenges-edam-etl:serve
> poetry run python src/main.py
Traceback (most recent call last):
File "/workspaces/sage-monorepo/apps/openchallenges/edam-etl/src/main.py", line 6, in <module>
import mariadb
ModuleNotFoundError: No module named 'mariadb'
Warning: command "poetry run python src/main.py" exited with non-zero status code
Serve-detach
$ nx run-many --target=build-image --projects=openchallenges-mariadb,openchallenges-edam-etl
$ nx serve-detach openchallenges-edam-etl
$ docker logs openchallenges-edam-etl
Traceback (most recent call last):
File "/opt/app/src/main.py", line 6, in <module>
import mariadb
ModuleNotFoundError: No module named 'mariadb'
Quality Gate passed for 'openchallenges-edam-etl'Issues Measures |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
I have found a solution for this module not found error by updating the command associated with the nx serve command in the project.json for edam-etl to multiple commands that execute to ensure that the mariadb and sqlalchemy, an issue I discovered after correcting the mariadb issue, are installed. I've also removed the unused "import mysql.connector" package from the ./src/main.py file. These changes have impacted the results of running
This then caused an error in the CI/pr check to fail for the same reasons when building the dev container by running The command
The output was:
|
What is this command? It's not list under |
@tschaffter My apologies. That command was my mistake in typing. It should be |
@tschaffter Would you be able to provide some insight into what's going on with
The EDAM_1.25.csv should be created within the container as it runs but I'd think that if it wasn't actively running then it wouldn't exist anymore. Please let me know if I'm misunderstanding. |
…e unused packages from poetry.lock
Description
This is the most recent branch for this issue.
EDAM ETL processes need to be developed to incorporate ETAM ontology in the Maria DB linking the ontology to existing data. This PR will address the load portion.
Related Issue
Contribute to #2524
Contribute to #2548
Replaces #2680
Changelog
Preview
This is the output as the project is run using
nx serve openchallenges-edam-etl
:nx prepare openchallenges-edam-etl
was also tested and the resulting output is:nx serve-detach openchallenges-edam-etl
was used to run the project using Docker and the resulting output is: