Bug Fix: Fix issue with trailing comma creating an empty node #1329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fix for issue described in FDS-1392.
To Reproduce
Using the current
develop-refactor-schemas
branch, attempt converting attachedEL.data.model.csv
(see below) to JSONLD with the following CLI command:It should error.
To Test
Use the fix branch with the same model and command, and it should pass.
For sanity, you can test the model where I deleted the problematic comma, and it goes through the conversion on the current branch.
EL_del_comma.data.model.csv
EL.data.model.csv