-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move methods of creating multiple manifests from API to manifest generator #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewelamb
reviewed
Dec 6, 2023
andrewelamb
reviewed
Dec 7, 2023
andrewelamb
reviewed
Dec 7, 2023
@andrewelamb do you think this PR is ready? |
@mialy-defelice I have some unresolved comments from last week. |
andrewelamb
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Move some methods that were previously in
routes.py
to ManifestGenerator without going through refactor. Related to FDS-1350.Changelog
get_manifest_route
in routes.py to an independent function inManifestGenerator
get_manifest_route
toManifestGenerator
.mg.create_manifests
to generate multiple or single manifestscreate_single_manifest
andcreate_manifests
and reorganize some of the parametersTest
Got expected output: a new patient manifest gets generated. The return contains one google sheet link.
Got expected output: three manifests gets generated. The return contains three google sheet link.
Got expected output: one manifest gets generated. The return contains one google sheet link: https://docs.google.com/spreadsheets/d/1UECgUSxinXj2lJ02f0GASw0rRmSs-nHiJnAdBJMJBqc/edit#gid=0
Got expected output: An excel spreadsheet gets returned and then content of the manifest is the same as the one above
syn51547836
,syn51547837
google_sheet
Got expected output: Two google sheet urls got returned. (See here and here)
Got expected output: https://docs.google.com/spreadsheets/d/1o0ZL86TzAbcU3pT8c09pp6Uv5j5jlTJB68BU855URP0/edit#gid=0