Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated GX v0.15.x functions #1335

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Update deprecated GX v0.15.x functions #1335

merged 2 commits into from
Dec 11, 2023

Conversation

GiaJordan
Copy link
Contributor

@GiaJordan GiaJordan commented Dec 4, 2023 •
edited
Loading

Update GX functions that were deprecated in v0.15.48, current spec is ^0.15.0

@GiaJordan GiaJordan marked this pull request as draft December 4, 2023 21:58
@GiaJordan GiaJordan marked this pull request as ready for review December 5, 2023 20:55
@GiaJordan GiaJordan requested a review from andrewelamb December 5, 2023 20:55
@andrewelamb
Copy link
Contributor

@GiaJordan Will you go over this tomorrow at code review?

@GiaJordan
Copy link
Contributor Author

@andrewelamb sure, I can

@GiaJordan GiaJordan merged commit ca01a56 into develop Dec 11, 2023
3 checks passed
@GiaJordan GiaJordan deleted the develop-GX-functions-FDS-123 branch December 11, 2023 20:05
@linglp linglp restored the develop-GX-functions-FDS-123 branch December 13, 2023 23:13
@linglp
Copy link
Contributor

linglp commented Dec 13, 2023 •
edited
Loading

@GiaJordan @mialy-defelice I restored this branch and tried runningpytest -m rule_combos and found out that the tests are failing See issue FDS 1459

@linglp linglp deleted the develop-GX-functions-FDS-123 branch December 14, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewelamb andrewelamb andrewelamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiaJordan @andrewelamb @linglp