Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS and pin down trivy version #1531

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

thomasyu888
Copy link
Member

No description provided.

@thomasyu888 thomasyu888 changed the title Update CODEOWNERS Update CODEOWNERS and pin down trivy version Nov 1, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 1, 2024

@jaymedina
Copy link
Contributor

It still requests us all individually for review instead of a "schematic_developers" group. That's the expected behavior, right?

Copy link
Collaborator

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaymedina I think it will request the group instead for future PRs after this is merged 🤞🏻

@jaymedina
Copy link
Contributor

jaymedina commented Nov 1, 2024

This commit was made before the review request was made, which I assumed would have a group be the reviewer instead of the individuals (at least in this branch). @BWMac

@thomasyu888
Copy link
Member Author

This commit was made before the review request was made, which I assumed would have a group be the reviewer instead of the individuals (at least in this branch). @BWMac

@jaymedina since the new CODEOWNERS is on a feature branch,it will not take into effect until it's merged

@thomasyu888 thomasyu888 merged commit d1ef225 into develop Nov 1, 2024
7 checks passed
@thomasyu888 thomasyu888 deleted the thomasyu888-patch-1 branch November 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants