Stabilize a few UI checks in Chromatic #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nickgros
commented
May 19, 2023
•
nickgros
commented
- Update action to reference the pull request ref so the actual changes get deployed and tested
- Load Lato font in Storybook preview-head, since it looks like UI tests commonly get flagged as changed when the font doesn't load in time for the screenshot. See https://www.chromatic.com/docs/resource-loading
- Update SubsectionRowRenderer demo to use existing table. The previous table used in the demo no longer exists, and when that happens we show a skeleton that uses a random number to determine its appearance, which is obviously not stable for snapshots.
nickgros
commented
May 19, 2023
| @@ -1,8 +1,8 @@ | |||
| <script> | |||
| window.global = window | |||
| window.sql = {} | |||
There was a problem hiding this comment.
no longer needed since we removed the sql-parser package as a dependency
nickgros
commented
May 19, 2023
Comment on lines
-54
to
-58
| <script | ||
| crossorigin | ||
| src="https://unpkg.com/react-plotly.js@1.0.2/dist/create-plotly-component.js" | ||
| ></script> | ||
|
|
There was a problem hiding this comment.
This is included in our node_modules, we shouldn't need this script.
nickgros
commented
May 19, 2023
Comment on lines
-59
to
-68
| <script> | ||
| const currentStack = JSON.parse( | ||
| window.localStorage.getItem('SynapseReactClientStyleGuideStack') ?? 'null', | ||
| ) | ||
| if (currentStack) { | ||
| window.SRC = { | ||
| OVERRIDE_ENDPOINT_CONFIG: currentStack, | ||
| } | ||
| } | ||
| </script> |
There was a problem hiding this comment.
This was replaced by Storybook controls long ago
- Load Lato font in Storybook preview-head - Update SubsectionRowRenderer demo to use existing table
nickgros
force-pushed
the
stabilize-chromatic-1
branch
from
21f03c7 to
360588f
Compare
nickgros
commented
May 23, 2023
| @@ -17,6 +17,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3.1.0 | |||
| with: | |||
| ref: ${{ github.event.pull_request.head.ref }} | |||
There was a problem hiding this comment.
Deploy the pull request, not the main branch
nickgros
commented
May 23, 2023
Comment on lines
+123
to
+125
| if (isChromatic && document.fonts) { | ||
| loaders.push(fontLoader) | ||
| } |
There was a problem hiding this comment.
When deployed to Chromatic, wait for the font to load before rendering the story. This should make our screenshots more stable
nickgros
commented
May 23, 2023
| args: { | ||
| sql: 'SELECT funderName as "Funding Agency" FROM syn26344829', |
There was a problem hiding this comment.
This table has been deleted and the fallback is a skeleton with a random length. Update the story with a different table.
jay-hodgson
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.