Skip to content

Commit

Permalink
Merge pull request #3919 from Sage/no_skip_ci
Browse files Browse the repository at this point in the history
build: run builds on all commits to master FE-4029
  • Loading branch information
Jamie Thompson authored Apr 15, 2021
2 parents d703c7b + 3862e2e commit 127511f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 0 additions & 2 deletions docs/testing-styleguide.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,6 @@ Where functionality is already tested in unit testing, this does not need to be

[Chromatic](https://www.chromatic.com/builds?appId=5ecf782fe724630022d27d7d) is used to test for visual regressions during each build by comparing snapshots of the storybook canvas with previous baseline snapshots. Chromatic automatically snapshots every story canvas. You should not need to run Chromatic locally.

For releasing a group of `BREAKING CHANGES` we agreed to create a `major/**` branch to avoid draining `chromatic` resources. After creating the `major/**` branch we need to run `git checkout major/**` and run `npx chromatic --project-token=CHROMATIC_PROJECT_TOKEN` to manually trigger a `chromatic` build on the `major/**` branch to perform a comparison with `master`. It allows us to merge the `BREAKING CHANGES` into the `major/**` branch without running `chromatic`.

##### Cypress File Structure
```
.
Expand Down
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@
"@semantic-release/release-notes-generator",
"@semantic-release/changelog",
"@semantic-release/npm",
"@semantic-release/git",
["@semantic-release/git", {
"message": "chore(release): ${nextRelease.version}\n\n${nextRelease.notes}"
}],
"@semantic-release/github"
]
}
Expand Down

0 comments on commit 127511f

Please sign in to comment.