Merge pull request #7129 from Sage/pw_remove_awaits

test: remove unnecessary awaits

src/components/accordion/accordion.pw.tsx

@@ -262,8 +262,8 @@ test.describe("should render Accordion component", () => {
       await mount(<AccordionComponent size={size} />);
 
       const cssHeight = await getStyle(accordionTitleContainer(page), "height");
-      await expect(parseInt(cssHeight)).toBeLessThanOrEqual(height + 1);
-      await expect(parseInt(cssHeight)).toBeGreaterThanOrEqual(height - 1);
+      expect(parseInt(cssHeight)).toBeLessThanOrEqual(height + 1);
+      expect(parseInt(cssHeight)).toBeGreaterThanOrEqual(height - 1);
     });
   });
 
@@ -403,7 +403,7 @@ test.describe("should render Accordion component", () => {
       );
 
       const cssWidth = await getStyle(accordionTitleContainer(page), "width");
-      await expect(cssWidth).toContain(width);
+      expect(cssWidth).toContain(width);
     });
   });
 

src/components/card/card.pw.tsx

@@ -213,9 +213,9 @@ test.describe("Check Card component properties", () => {
           .locator('[data-component="card"]')
           .count();
 
-        await expect(resultForColumnOne).toEqual(countOfFirstColumn);
+        expect(resultForColumnOne).toEqual(countOfFirstColumn);
 
-        await expect(resultForColumnTwo).toEqual(countOfSecondColumn);
+        expect(resultForColumnTwo).toEqual(countOfSecondColumn);
       });
     },
   );

src/components/date-range/date-range.pw.tsx

@@ -474,7 +474,7 @@ test.describe("Event tests for DateRange component", () => {
         getDataElementByValue(page, "input").nth(inputIndex);
       await getDataElementByValueElementInputEqInputIndex.clear();
 
-      await expect(callbackCount).toEqual(1);
+      expect(callbackCount).toEqual(1);
     });
   });
 
@@ -495,7 +495,7 @@ test.describe("Event tests for DateRange component", () => {
 
         await textboxInput(page).nth(inputIndex).type(value);
 
-        await expect(callbackCount).toEqual(value.length);
+        expect(callbackCount).toEqual(value.length);
       });
     });
   });
@@ -517,7 +517,7 @@ test.describe("Event tests for DateRange component", () => {
 
     await textboxInput(page).nth(START_DATE_RANGE_INDEX).type("1");
 
-    await expect(callbackCount).toEqual(1);
+    expect(callbackCount).toEqual(1);
   });
 });
 

src/components/detail/detail.pw.tsx

@@ -22,7 +22,7 @@ test.describe("check Detail component text input", () => {
     }) => {
       await mount(<Detail>{text}</Detail>);
 
-      await expect(await childrenPreview(page)).toHaveText(text);
+      await expect(childrenPreview(page)).toHaveText(text);
     });
 
     test(`check Detail footnote on preview is ${text} footnote value`, async ({
@@ -31,7 +31,7 @@ test.describe("check Detail component text input", () => {
     }) => {
       await mount(<Detail footnote={text} />);
 
-      await expect(await footnotePreview(page)).toHaveText(text);
+      await expect(footnotePreview(page)).toHaveText(text);
     });
   });
 });
@@ -42,9 +42,9 @@ test("should set Detail icon on preview to chevron_up", async ({
 }) => {
   await mount(<Detail icon="chevron_up" />);
 
-  await expect(await icon(page)).toHaveAttribute("type", "chevron_up");
+  await expect(icon(page)).toHaveAttribute("type", "chevron_up");
   const isVisible = await icon(page).isVisible();
-  await expect(await isVisible).toBeTruthy();
+  expect(isVisible).toBeTruthy();
 });
 
 test.describe("Accessibility tests for Detail component", () => {

src/components/file-input/file-input.pw.tsx

@@ -138,7 +138,7 @@ test.describe("FileInput component", () => {
       page,
     }) => {
       await mount(<FileInputComponent accept={accept} />);
-      const input = await hiddenInput(page, "File input");
+      const input = hiddenInput(page, "File input");
       await expect(input).toHaveAttribute("accept", accept);
     });
   });
@@ -149,7 +149,7 @@ test.describe("FileInput component", () => {
       page,
     }) => {
       await mount(<FileInputComponent buttonText={testVal} />);
-      const buttonElement = await selectFileButton(page, testVal);
+      const buttonElement = selectFileButton(page, testVal);
       await expect(buttonElement).toBeVisible();
     });
   });
@@ -170,9 +170,9 @@ test.describe("FileInput component", () => {
       page,
     }) => {
       await mount(<FileInputComponent label={testVal} />);
-      const input = await hiddenInput(page, testVal);
+      const input = hiddenInput(page, testVal);
       await expect(input).toHaveCount(1);
-      const labelElement = await label(page);
+      const labelElement = label(page);
       await expect(labelElement).toHaveText(testVal);
       await expect(labelElement).toBeVisible();
     });
@@ -184,7 +184,7 @@ test.describe("FileInput component", () => {
       page,
     }) => {
       await mount(<FileInputComponent inputHint={testVal} />);
-      const inputHintElement = await page.getByText(testVal);
+      const inputHintElement = page.getByText(testVal);
       await expect(inputHintElement).toBeVisible();
     });
   });
@@ -199,7 +199,7 @@ test.describe("FileInput component", () => {
           .getPropertyValue("border-color"),
       );
     // TODO: should check token value (--colorsSemanticNegative500), rewrite this when we have the equivalent playwright util merged in
-    await expect(borderColor).toBe("rgb(203, 55, 74)");
+    expect(borderColor).toBe("rgb(203, 55, 74)");
   });
 
   test("should render with string error prop", async ({ mount, page }) => {
@@ -212,16 +212,16 @@ test.describe("FileInput component", () => {
           .getPropertyValue("border-color"),
       );
     // TODO: should check token value (--colorsSemanticNegative500), rewrite this when we have the equivalent playwright util merged in
-    await expect(borderColor).toBe("rgb(203, 55, 74)");
-    const errorMessage = await page.getByText("error text");
+    expect(borderColor).toBe("rgb(203, 55, 74)");
+    const errorMessage = page.getByText("error text");
     await expect(errorMessage).toBeVisible();
     await expect(errorMessage).toHaveCSS("color", "rgb(203, 55, 74)");
   });
 
   specialCharacters.forEach((testVal) => {
     test(`should render with id '${testVal}'`, async ({ mount, page }) => {
       await mount(<FileInputComponent id={testVal} />);
-      const input = await hiddenInput(page, "File input");
+      const input = hiddenInput(page, "File input");
       await expect(input).toHaveAttribute("id", testVal);
     });
   });
@@ -330,12 +330,12 @@ test.describe("with uploadStatus prop", () => {
         uploadStatus={{ ...uploadingStatusProps, onAction }}
       />,
     );
-    const actionButton = await page.getByRole("button", {
+    const actionButton = page.getByRole("button", {
       name: "Cancel upload",
     });
     await expect(actionButton).toBeVisible();
     await actionButton.click();
-    await expect(clickCount).toBe(1);
+    expect(clickCount).toBe(1);
   });
 
   test("in the uploading state, it renders the file name, but not as a link", async ({
@@ -371,9 +371,9 @@ test.describe("with uploadStatus prop", () => {
         uploadStatus={{ ...uploadingStatusProps, progress: undefined }}
       />,
     );
-    const loaderBar = await page.getByRole("progressbar");
+    const loaderBar = page.getByRole("progressbar");
     await expect(loaderBar).toBeVisible();
-    await expect(await loaderBar.getAttribute("aria-valuenow")).toBeNull();
+    expect(await loaderBar.getAttribute("aria-valuenow")).toBeNull();
   });
 
   test("in the completed state, it renders a status message", async ({
@@ -397,20 +397,20 @@ test.describe("with uploadStatus prop", () => {
         uploadStatus={{ ...completedStatusProps, onAction }}
       />,
     );
-    const actionButton = await page.getByRole("button", {
+    const actionButton = page.getByRole("button", {
       name: "Delete file",
     });
     await expect(actionButton).toBeVisible();
     await actionButton.click();
-    await expect(clickCount).toBe(1);
+    expect(clickCount).toBe(1);
   });
 
   test("in the completed state, it renders the file name as a link with the provided props", async ({
     mount,
     page,
   }) => {
     await mount(<FileInputComponent uploadStatus={completedStatusProps} />);
-    const link = await page.getByRole("link", { name: "foo.pdf" });
+    const link = page.getByRole("link", { name: "foo.pdf" });
     await expect(link).toBeVisible();
     await expect(link).toHaveAttribute("href", "http://carbon.sage.com");
     await expect(link).toHaveAttribute("target", "_blank");
@@ -438,7 +438,7 @@ test.describe("with uploadStatus prop", () => {
     page,
   }) => {
     await mount(<FileInputComponent uploadStatus={previouslyStatusProps} />);
-    const link = await page.getByRole("link", { name: "foo.pdf" });
+    const link = page.getByRole("link", { name: "foo.pdf" });
     await expect(link).toBeVisible();
     await expect(link).toHaveAttribute("href", "http://carbon.sage.com");
     await expect(link).toHaveAttribute("target", "_blank");
@@ -458,12 +458,12 @@ test.describe("with uploadStatus prop", () => {
         uploadStatus={{ ...previouslyStatusProps, onAction }}
       />,
     );
-    const actionButton = await page.getByRole("button", {
+    const actionButton = page.getByRole("button", {
       name: "Delete file",
     });
     await expect(actionButton).toBeVisible();
     await actionButton.click();
-    await expect(clickCount).toBe(1);
+    expect(clickCount).toBe(1);
   });
 
   test("in the previously state, it does not render a progress bar", async ({
@@ -493,10 +493,10 @@ test.describe("with uploadStatus prop", () => {
     await mount(
       <FileInputComponent uploadStatus={{ ...errorStatusProps, onAction }} />,
     );
-    const actionButton = await page.getByRole("button", { name: "Clear" });
+    const actionButton = page.getByRole("button", { name: "Clear" });
     await expect(actionButton).toBeVisible();
     await actionButton.click();
-    await expect(clickCount).toBe(1);
+    expect(clickCount).toBe(1);
   });
 
   test("in the error state, it renders the file name, but not as a link", async ({
@@ -558,8 +558,8 @@ test.describe("interactions", () => {
       fileName: "README.md",
       fileType: "text/markdown",
     });
-    await expect(onChangeCalls.length).toBe(1);
-    await expect(onChangeCalls[0]).toMatchObject({
+    expect(onChangeCalls.length).toBe(1);
+    expect(onChangeCalls[0]).toMatchObject({
       name: "README.md",
       type: "text/markdown",
     });
@@ -585,7 +585,7 @@ test.describe("interactions", () => {
           .getComputedStyle(el.parentElement as HTMLElement)
           .getPropertyValue("border-width"),
       );
-    await expect(borderWidth).toBe("2px");
+    expect(borderWidth).toBe("2px");
   });
 
   test("when dragging a file off the document, the component border returns to the original thickness", async ({
@@ -616,7 +616,7 @@ test.describe("interactions", () => {
           .getComputedStyle(el.parentElement as HTMLElement)
           .getPropertyValue("border-width"),
       );
-    await expect(borderWidth).toBe("1px");
+    expect(borderWidth).toBe("1px");
   });
 
   test("after dropping a file, the component border returns to the original thickness", async ({
@@ -647,7 +647,7 @@ test.describe("interactions", () => {
           .getComputedStyle(el.parentElement as HTMLElement)
           .getPropertyValue("border-width"),
       );
-    await expect(borderWidth).toBe("1px");
+    expect(borderWidth).toBe("1px");
   });
 
   test("while dragging a file with the component in the error state, the border color changes", async ({
@@ -671,7 +671,7 @@ test.describe("interactions", () => {
           .getPropertyValue("border-color"),
       );
     // TODO: should check token value (--colorsSemanticNegative600), rewrite this when we have the equivalent playwright util merged in
-    await expect(borderColor).toBe("rgb(162, 44, 59)");
+    expect(borderColor).toBe("rgb(162, 44, 59)");
   });
 
   test("while dragging a file over the component, the background color changes", async ({
@@ -694,7 +694,7 @@ test.describe("interactions", () => {
           .getComputedStyle(el.parentElement as HTMLElement)
           .getPropertyValue("background-color"),
       );
-    await expect(backgroundColor).toBe("rgb(204, 214, 219)");
+    expect(backgroundColor).toBe("rgb(204, 214, 219)");
   });
 });
 

src/components/heading/heading.pw.tsx

@@ -127,8 +127,8 @@ test.describe("Heading component", () => {
   }) => {
     await mount(<HeadingComponent backLink="https://carbon.sage.com/" />);
 
-    const linkWrapper = await link(page);
-    const backLinkAnchor = await linkWrapper.locator("a");
+    const linkWrapper = link(page);
+    const backLinkAnchor = linkWrapper.locator("a");
     await backLinkAnchor.focus();
     await expect(backLinkAnchor).toHaveCSS(
       "box-shadow",

src/components/hr/hr.pw.tsx

@@ -31,7 +31,7 @@ test.describe("Hr component", () => {
       mount,
       page,
     }) => {
-      await await mount(
+      await mount(
         <HrComponent
           mb={7}
           mt={7}

src/components/pages/pages.pw.tsx

@@ -74,7 +74,7 @@ test.describe("Prop checks for Pages component", () => {
       await dataComponentButtonByText(page, "Go to second page").click();
       const classAttribute = await pageComponent.getAttribute("class");
 
-      await expect(classAttribute).toContain(transition);
+      expect(classAttribute).toContain(transition);
     });
   });