chore: address comments from review

Sage · Nov 19, 2024 · 8b422f8 · 8b422f8
1 parent 183f165
commit 8b422f8
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 27 deletions.
diff --git a/src/components/accordion/accordion.style.ts b/src/components/accordion/accordion.style.ts
@@ -153,7 +153,6 @@ const StyledAccordionTitleContainer = styled.div<StyledAccordionTitleContainerPr
     iconAlign,
     size,
     hasButtonProps,
-    theme,
     isExpanded,
     variant,
   }) => css`

diff --git a/src/components/action-popover/action-popover.style.ts b/src/components/action-popover/action-popover.style.ts
@@ -246,12 +246,9 @@ const ButtonIcon = styled(Icon)`
 `;
 
 const StyledButtonIcon = styled.div`
-  ${({ theme }) =>
-    `
-    &:focus {
-      ${addFocusStyling()}
-    }    
-  `}
+  &:focus {
+    ${addFocusStyling()}
+  }
   border-radius: var(--borderRadius050);
 `;
 

diff --git a/src/components/button/button.style.ts b/src/components/button/button.style.ts
@@ -74,7 +74,7 @@ type StyledButtonProps = SpaceProps &
 
 const StyledButton = styled.button<StyledButtonProps>`
   ${space}
-  ${({ disabled, noWrap, theme }) => css`
+  ${({ disabled, noWrap }) => css`
     align-items: center;
     cursor: ${disabled ? "not-allowed" : "pointer"};
     display: inline-flex;

diff --git a/src/components/card/card.style.ts b/src/components/card/card.style.ts
@@ -105,7 +105,7 @@ const StyledCardContent = styled.div.attrs(
     return {};
   },
 )<StyledCardContentProps>`
-  ${({ interactive, theme }) =>
+  ${({ interactive }) =>
     interactive &&
     css`
       cursor: pointer;

diff --git a/src/components/date/__internal__/date-picker/day-picker.style.ts b/src/components/date/__internal__/date-picker/day-picker.style.ts
@@ -265,12 +265,9 @@ const StyledDayPicker = styled.div`
       color: var(--colorsActionMajorYin090);
     }
 
-    ${({ theme }) =>
-      `
-      &:focus {
-        ${addFocusStyling(true)}
-      }
-    `}
+    &:focus {
+      ${addFocusStyling(true)}
+    }
 
     + * {
       border-left: 1px;

diff --git a/src/components/duelling-picklist/picklist-item/picklist-item.test.tsx b/src/components/duelling-picklist/picklist-item/picklist-item.test.tsx
@@ -79,7 +79,7 @@ test("the context callback is called with the expected arguments when isLastItem
 });
 
 // test purely for coverage - the `locked` prop is tested in both Chromatic and Playwright
-test("should render a locked icon with expected styling when the `locked` prop is set and the focusRedesignOptOut flag is set", () => {
+test("should render a locked icon with expected styling when the `locked` prop is set", () => {
   render(
     <PicklistItem type="add" onChange={() => {}} item={1} locked>
       Item content

diff --git a/src/components/menu/menu-full-screen/menu-full-screen.style.ts b/src/components/menu/menu-full-screen/menu-full-screen.style.ts
@@ -64,7 +64,7 @@ const StyledMenuModal = styled.div<{ menuType: MenuType }>`
     }
   }
 
-  ${({ menuType, theme }) => css`
+  ${({ menuType }) => css`
     background-color: ${menuConfigVariants[menuType].background};
 
     && {

diff --git a/src/components/split-button/split-button-toggle.style.ts b/src/components/split-button/split-button-toggle.style.ts
@@ -19,7 +19,7 @@ type StyledSplitButtonToggleProps = {
 const StyledSplitButtonToggle = styled(
   StyledButton,
 )<StyledSplitButtonToggleProps>`
-  ${({ buttonType, disabled, displayed, size, theme }) => css`
+  ${({ buttonType, disabled, displayed, size }) => css`
     border-top-left-radius: var(--borderRadius000);
     border-bottom-left-radius: var(--borderRadius000);
 

diff --git a/src/components/switch/switch.style.ts b/src/components/switch/switch.style.ts
@@ -69,13 +69,7 @@ export const StyledHintText = styled.div<StyledHintTextProps>`
 `;
 
 const StyledSwitch = styled.div`
-  ${({
-    fieldHelpInline,
-    labelInline,
-    reverse,
-    size,
-    theme,
-  }: StyledSwitchProps) => css`
+  ${({ fieldHelpInline, labelInline, reverse, size }: StyledSwitchProps) => css`
     ${margin}
     ${FieldLineStyle} {
       display: flex;

diff --git a/src/components/text-editor/text-editor.style.ts b/src/components/text-editor/text-editor.style.ts
@@ -68,7 +68,7 @@ const StyledEditorOutline = styled.div<{
   isFocused?: boolean;
   hasError?: boolean;
 }>`
-  ${({ isFocused, hasError, theme }) => css`
+  ${({ isFocused, hasError }) => css`
     border-radius: var(--borderRadius050);
     outline: none;
 

diff --git a/src/components/tile-select/tile-select.style.ts b/src/components/tile-select/tile-select.style.ts
@@ -68,7 +68,7 @@ const StyledFocusWrapper = styled.div<{
   checked?: boolean;
   hasFocus: boolean;
 }>`
-  ${({ checked, hasFocus, theme }) => css`
+  ${({ checked, hasFocus }) => css`
     position: relative;
     border: 1px solid var(--colorsActionMinor250);
     border-radius: var(--borderRadius100);
-Original file line number
+Diff line change
@@ Expand Up / @@ -64,7 +64,7 @@ const StyledMenuModal = styled.div<{ menuType: MenuType }>` @@
         }
       }
-      ${({ menuType, theme }) => css`
+      ${({ menuType }) => css`
         background-color: ${menuConfigVariants[menuType].background};
         && {
@@ Expand Down @@