-
Notifications
You must be signed in to change notification settings - Fork 85
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(sidebar): add aria-labelledby referencing title if not provided
Give guid as id to sidebar header container, and provide this as the aria-lablledby to the sidebar container if no aria-label or aria-labelledby prop is provided. This improves accessibility and makes Sidebar consistent with DialogFullScreen. It also fixes an issue with the previous commit where, with Voiceover on, opening the sidebar places focus on the header rather than the sidebar container.
- Loading branch information
1 parent
0a6a2b0
commit a2c795a
Showing
3 changed files
with
29 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters