Skip to content

Commit

Permalink
fix(definition-list): fix dl focused elements outline cut by "overflo…
Browse files Browse the repository at this point in the history
…w: hidden"
  • Loading branch information
Michał Maciorowski committed Apr 26, 2021
1 parent 5c29bbc commit f7ca1d3
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 9 deletions.
22 changes: 14 additions & 8 deletions src/components/definition-list/definition-list.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,20 @@ describe("DefinitionList", () => {
);
};

testStyledSystemSpacing((props) => (
<ThemeProvider theme={mintTheme}>
<Dl {...props}>
<Dt>Description</Dt>
<Dd>This is a test</Dd>
</Dl>
</ThemeProvider>
));
testStyledSystemSpacing(
(props) => (
<ThemeProvider theme={mintTheme}>
<Dl {...props}>
<Dt>Description</Dt>
<Dd>This is a test</Dd>
</Dl>
</ThemeProvider>
),
{
px: "3px",
mx: "-3px",
}
);

describe("dt", () => {
testStyledSystemSpacing(
Expand Down
4 changes: 3 additions & 1 deletion src/components/definition-list/dl.component.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ const Dl = ({
w = 50,
dtTextAlign = "right",
ddTextAlign = "left",
px = "3px",
mx = "-3px",
...props
}) => {
const dlComponent = [];
Expand Down Expand Up @@ -57,7 +59,7 @@ const Dl = ({
};

return (
<StyledDl w={w} data-component="dl" {...props}>
<StyledDl w={w} px={px} mx={mx} data-component="dl" {...props}>
{composeDlComponent(listChildren)}
</StyledDl>
);
Expand Down

0 comments on commit f7ca1d3

Please sign in to comment.