Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments for padding on buttons #1523

Closed
toni-sharpe opened this issue Sep 5, 2017 · 1 comment
Closed

Adjustments for padding on buttons #1523

toni-sharpe opened this issue Sep 5, 2017 · 1 comment
Labels
Bug

Comments

@toni-sharpe
Copy link

toni-sharpe commented Sep 5, 2017 •
edited
Loading

Problem

image

The component is defining it's layout by pushing components around it apart unless it has errors showing. The alignment is more important than leaving space for the validations design.

Solution

image

Achieved by adding margin: -8px to Carbon Form Summary
@toni-sharpe toni-sharpe added the Bug label Sep 5, 2017
@toni-sharpe toni-sharpe self-assigned this Sep 5, 2017
toni-sharpe pushed a commit that referenced this issue Sep 5, 2017
Fix Form Summary Button position bug #1523
0edd73a
@toni-sharpe toni-sharpe mentioned this issue Sep 5, 2017
Merged
1 task
abramin added a commit that referenced this issue Sep 6, 2017
@abramin
Merge pull request #1524 from Sage/1523-fix-button-position
8811ea5 
Fix Form Summary Button position bug #1523
@andrewjtait
Copy link
Contributor

Fixed as of v1.5.3

screen shot 2017-10-18 at 14 05 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewjtait @toni-sharpe