Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlatTable - height issue #3850

Closed
harpalsingh opened this issue Mar 22, 2021 · 2 comments · Fixed by #3871
Closed

FlatTable - height issue #3850

harpalsingh opened this issue Mar 22, 2021 · 2 comments · Fixed by #3871
Labels
Bug On Backlog released Squad Nebula

Comments

@harpalsingh
Copy link
Member

Current behaviour

When hasStickyHead is added to FlatTable, a height: 100% is added to a table, this causes the following issue based on layout decisions:

Screenshot 2021-03-22 at 15 53 46

code:

Screenshot 2021-03-22 at 15 55 27

Expected behaviour

Either the table should have an adequate background/borders or a max-height: 100% option, rather than height:100%

Suggested solution(s)

Allow the option of either using max-height:100%, or if height: 100% is used then we need correct background and border styling and not a transparent gap.
@harpalsingh harpalsingh added Bug triage Triage Required labels Mar 22, 2021
@dawidzarzycki
Copy link
Contributor

FE-3986

@dawidzarzycki dawidzarzycki added On Backlog and removed triage Triage Required labels Mar 25, 2021
@DipperTheDan DipperTheDan mentioned this issue Apr 1, 2021
Merged
8 tasks
DipperTheDan added a commit that referenced this issue Apr 8, 2021
@DipperTheDan
fix(flat-table): fix gap between table content and sticky footer
c547f4e 
Provides a fix for the gap between table content and sticky footer when certain design decisions are
applied to FlatTable.

fixes #3850
carbonci pushed a commit that referenced this issue Apr 8, 2021
@semantic-release-bot @carbonci
chore(release): 68.9.2 [skip ci]
c78a8bf 
### [68.9.2](v68.9.1...v68.9.2) (2021-04-08)

### Bug Fixes

* **flat-table:** fix gap between table content and sticky footer ([c547f4e](c547f4e)), closes [#3850](#3850)
@carbonci
Copy link
Collaborator

carbonci commented Apr 8, 2021

🎉 This issue has been resolved in version 68.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released Squad Nebula
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(FlatTable): fix gap between table content and sticky footer - FE-3986 Sage/carbon
4 participants
@harpalsingh @dawidzarzycki @ian-forster @carbonci