Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blur not fired when TileSelect disabled #4227

Closed
maspychaj-sage opened this issue Jul 8, 2021 · 2 comments · Fixed by #4233
Closed

Blur not fired when TileSelect disabled #4227

maspychaj-sage opened this issue Jul 8, 2021 · 2 comments · Fixed by #4233
Labels
Bug On Backlog released

Comments

@maspychaj-sage
Copy link
Contributor

Current behaviour

When TileSelect was selected and later disabled the outline is not removed on click other element.

Expected behaviour

No outline after blur on disabled TileSelect

Reproducible example

https://codesandbox.io/s/sharp-bartik-0gou9?file=/src/index.js

Additional context

React issue might be related: facebook/react#9142

Your environment

Software Version(s)
carbon-react 77.7.2
@maspychaj-sage maspychaj-sage added Bug triage Triage Required labels Jul 8, 2021
@edleeks87
Copy link
Contributor

FE-4218

@edleeks87 edleeks87 added On Backlog and removed triage Triage Required labels Jul 9, 2021
edleeks87 added a commit that referenced this issue Jul 9, 2021
@edleeks87
fix(tile-select): prevent focus outline when tile select is disabled
e6c9a17 
Adds `useEffect` to set `hasFocus` to false if `disabled` prop is set

fix #4227
@edleeks87 edleeks87 mentioned this issue Jul 9, 2021
Merged
8 tasks
carbonci pushed a commit that referenced this issue Jul 15, 2021
@semantic-release-bot @carbonci
chore(release): 77.12.2
a6b9e26 
### [77.12.2](v77.12.1...v77.12.2) (2021-07-15)

### Bug Fixes

* **tile-select:** prevent focus outline when tile select is disabled ([e6c9a17](e6c9a17)), closes [#4227](#4227)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 77.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edleeks87 edleeks87 mentioned this issue Aug 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tile-select): prevent focus outline when tile select is disabled Sage/carbon
3 participants
@edleeks87 @carbonci @maspychaj-sage