Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionPopoverMenuButton - Stay open behind when we open a Dialog #4662

Closed
1 task done
hegou33 opened this issue Dec 29, 2021 · 2 comments · Fixed by #4781
Closed
1 task done

ActionPopoverMenuButton - Stay open behind when we open a Dialog #4662

hegou33 opened this issue Dec 29, 2021 · 2 comments · Fixed by #4781

Comments

@hegou33
Copy link
Contributor

hegou33 commented Dec 29, 2021

Current behaviour

When using ActionPopoverMenuButton in a FlatTable with the keyboard, this one stay open when we open a dialog.

Expected behaviour

ActionPopover would be closed when we open a dialog in front of, like when we use the mouse.

CodeSandbox or Storybook URL

https://codesandbox.io/s/black-moon-ugf2n?file=/src/index.js

JIRA Ticket (Sage Only)

SBS-25708

Suggested Solution

No response

Carbon Version

101.4.2

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

Windows

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@hegou33 hegou33 added Bug triage Triage Required labels Dec 29, 2021
@jamime jamime added On Backlog and removed triage Triage Required labels Jan 5, 2022
@jamime
Copy link

jamime commented Jan 5, 2022

FE-4703

This is now in progress.

This is caused because when we move the focus, the click event triggers on the button re-opening the menu.

I have been unable to reproduce this in cypress and I have raised cypress-io/cypress#19541 I'll create a unit test for this instead. It would be good to add a cypress test once the cypress issue above is resolved.

DipperTheDan added a commit that referenced this issue Feb 3, 2022
…board nav

Fixes a bug whereby the popover would stay open when a dialog was opened from Action Popover using
keyboard navigation.

fixes #4662
DipperTheDan added a commit that referenced this issue Feb 7, 2022
…board nav

Fixes a bug whereby the popover would stay open when a dialog was opened from Action Popover using
keyboard navigation.

fixes #4662
edleeks87 pushed a commit that referenced this issue Mar 4, 2022
…board nav

Fixes a bug whereby the popover would stay open when a dialog was opened from Action Popover using
keyboard navigation.

fixes #4662
edleeks87 pushed a commit that referenced this issue Mar 8, 2022
…board nav

Fixes a bug whereby the popover would stay open when a dialog was opened from Action Popover using
keyboard navigation.

fixes #4662
carbonci pushed a commit that referenced this issue Mar 15, 2022
### [104.54.3](v104.54.2...v104.54.3) (2022-03-15)

### Bug Fixes

* **action-popover-item:** prevent popover staying open when using keyboard nav ([6c03ae3](6c03ae3)), closes [#4662](#4662)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 104.54.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants