Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not consistent padding/margin in radio and checkbox #4670

Closed
1 task done
maspychaj-sage opened this issue Jan 5, 2022 · 2 comments
Closed
1 task done

Not consistent padding/margin in radio and checkbox #4670

maspychaj-sage opened this issue Jan 5, 2022 · 2 comments
Labels
Bug On Backlog released

Comments

@maspychaj-sage
Copy link
Contributor

Current behaviour

Radio button has margin-bottom 12px and checkbox has padding-top 12px. It causes issues with wrong spacing between label and fields (for radio it's 8px, for checkbox it's 20px).

image

Expected behaviour

Spacing should be the same in both cases.

CodeSandbox or Storybook URL

https://codesandbox.io/s/modern-snow-p09k6?file=/src/index.js

JIRA Ticket (Sage Only)

RIV-580

Suggested Solution

No response

Carbon Version

102.4.6

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

What Operating System are you seeing the problem on?

MacOS, Windows, Linux

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@maspychaj-sage maspychaj-sage added Bug triage Triage Required labels Jan 5, 2022
@mkrds mkrds added Design System Review Required DS team to review changes and removed Design System Review Required DS team to review changes labels Jan 11, 2022
@mkrds
Copy link
Contributor

mkrds commented Jan 11, 2022

FE-4718

@mkrds mkrds added On Backlog and removed triage Triage Required labels Jan 11, 2022
carbonci pushed a commit that referenced this issue Jan 17, 2022
@semantic-release-bot @carbonci
chore(release): 102.13.0
d6d7040 
## [102.13.0](v102.12.0...v102.13.0) (2022-01-17)

### Features

* **checkbox:** change spacing to match radio button group ([50a6ab4](50a6ab4)), closes [#4670](#4670)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 102.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkrds @carbonci @maspychaj-sage