Unable to select options from SplitButton with keyboard if children are link buttons #4784
Closed
1 task done
Labels
Comments
|
FE-4920 |
robinzigmond
added a commit
that referenced
this issue
Jul 18, 2023
SplitButton and MultiActionButton used to clone their children and pass particular props, including refs - assuming each child was a Button component. This meant that the components failed to work properly when using custom child components that wrap one or more Carbon Buttons (at least unless forwardRef was used). This has now been replaced by a context-based approach using DOM selectors to achieve the same functionality no matter how the children are composed. fix #4784
14 tasks
robinzigmond
added a commit
that referenced
this issue
Jul 24, 2023
SplitButton and MultiActionButton used to clone their children and pass particular props, including refs - assuming each child was a Button component. This meant that the components failed to work properly when using custom child components that wrap one or more Carbon Buttons (at least unless forwardRef was used). This has now been replaced by a context-based approach using DOM selectors to achieve the same functionality no matter how the children are composed. fix #4784
robinzigmond
added a commit
that referenced
this issue
Aug 1, 2023
SplitButton and MultiActionButton used to clone their children and pass particular props, including refs - assuming each child was a Button component. This meant that the components failed to work properly when using custom child components that wrap one or more Carbon Buttons (at least unless forwardRef was used). This has now been replaced by a context-based approach using DOM selectors to achieve the same functionality no matter how the children are composed. fix #4784
carbonci
pushed a commit
that referenced
this issue
Aug 4, 2023
### [119.9.3](v119.9.2...v119.9.3) (2023-08-04) ### Bug Fixes * **split-button, multi-action-button:** remove children iteration ([a8631bc](a8631bc)), closes [#4784](#4784)
|
🎉 This issue has been resolved in version 119.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behaviour
On Sage 200 some of our SplitButtons contain children which are links. For this we make carbon buttons into links following the example given in the usage with routing documentation.
When a user tries to use the keyboard to select an option from the split button, they are unable to. In the console we see
Uncaught TypeError: additionalButtons.current[nextIndex].focus is not a functionfrom within the Carbon SplitButton component.Impacts accessibility and slows down our power users who like to use the keyboard.
Expected behaviour
User should be able to select options from the dropdown with their keyboard as when the split button has only buttons as children.
CodeSandbox or Storybook URL
https://codesandbox.io/s/bold-sunset-ztpoc?file=/src/index.js
JIRA Ticket (Sage Only)
No response
Suggested Solution
No response
Carbon Version
104.0.0
What browsers are you seeing the problem on?
Firefox, Chrome
What Operating System are you seeing the problem on?
Windows
Anything else we should know?
Also applies to the MultiActionButton
Confidentiality
The text was updated successfully, but these errors were encountered: