Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-role tag to all components in the flat table folder #4862

Closed
1 task done
stephenpowers-sage opened this issue Feb 18, 2022 · 2 comments · Fixed by #4886
Closed
1 task done

Add data-role tag to all components in the flat table folder #4862

stephenpowers-sage opened this issue Feb 18, 2022 · 2 comments · Fixed by #4886
Labels
Enhancement On Backlog released

Comments

@stephenpowers-sage
Copy link

Desired behaviour

We require data-role tag on the components for automation tests. These were present on the old table comopenents.

Current behaviour

There is no data-role tag on the flat-table components.

Suggested Solution

Add the data-role tag for the flat-table components. Most of the carbon components have these but a handful does not. Could we look to add data-role tags for all components please for the reasons outlined above?

CodeSandbox or Storybook URL

No response

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@samtjo
Copy link
Contributor

samtjo commented Feb 22, 2022

FE-4980

@samtjo samtjo added On Backlog and removed triage Triage Required labels Feb 22, 2022
samtjo added a commit that referenced this issue Feb 23, 2022
@samtjo
feat(flat-table): add ability to use data-xxx props on flat table com…
11b365d 
…ponents

Fixes: #4862

You can now add any data-xxx prop onto the following components:
FlatTable
FlatTableBody
FlatTableBodyDraggable
FlatTableCell
FlatTableCheckbox
FlatTableHead
FlatTableHeader
FlatTableRow
FlatTableRowHeader

They will be added onto the root element of the component.
@samtjo samtjo mentioned this issue Feb 23, 2022
Merged
13 tasks
carbonci pushed a commit that referenced this issue Mar 8, 2022
@semantic-release-bot @carbonci
chore(release): 104.52.0
13ffb28 
## [104.52.0](v104.51.0...v104.52.0) (2022-03-08)

### Features

* **flat-table:** add ability to use data-xxx props on flat table components ([11b365d](11b365d)), closes [#4862](#4862)
@carbonci
Copy link
Collaborator

carbonci commented Mar 8, 2022

🎉 This issue has been resolved in version 104.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(flat-table): add ability to use data-xxx props on flat table com… Sage/carbon
3 participants
@samtjo @carbonci @stephenpowers-sage