Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use to aria-label for Buttons with Label #5311

Closed
1 task done
kohli-pratik-sage opened this issue Jul 14, 2022 · 2 comments · Fixed by #5439
Closed
1 task done

Allow the use to aria-label for Buttons with Label #5311

kohli-pratik-sage opened this issue Jul 14, 2022 · 2 comments · Fixed by #5439
Labels
Enhancement On Backlog released Squad Nebula

Comments

@kohli-pratik-sage
Copy link

Desired behaviour

Presently the <Button /> component does not allow the addition of aria-label when button text is provided. The request here is to allow the addition of aria-label in addition to button text so it allows providing context to users using assistive technologies - screen readers, speech recognition.

Current behaviour

Presently the <Button /> component does not allow the addition of aria-label when button text is provided.

Suggested Solution

No response

CodeSandbox or Storybook URL

No response

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@nicktitchmarsh
Copy link
Contributor

FE-5279

@nicktitchmarsh nicktitchmarsh added On Backlog Squad Nebula and removed triage Triage Required labels Jul 19, 2022
@grabkowski grabkowski mentioned this issue Sep 1, 2022
Merged
8 tasks
carbonci pushed a commit that referenced this issue Sep 12, 2022
@semantic-release-bot @carbonci
chore(release): 110.6.1
cebca66 
### [110.6.1](v110.6.0...v110.6.1) (2022-09-12)

### Bug Fixes

* **button:** always pass aria-label down to the html element ([286f668](286f668)), closes [#5311](#5311)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 110.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

grabkowski pushed a commit that referenced this issue Sep 22, 2022
@semantic-release-bot @grabkowski
chore(release): 110.6.1
d8e5c87 
### [110.6.1](v110.6.0...v110.6.1) (2022-09-12)

### Bug Fixes

* **button:** always pass aria-label down to the html element ([286f668](286f668)), closes [#5311](#5311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement On Backlog released Squad Nebula
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): always pass aria-label down to the html element (FE-5279) Sage/carbon
3 participants
@carbonci @nicktitchmarsh @kohli-pratik-sage