Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DialogSizes no longer exported #5516

Closed
1 task done
PaulSumner-Sage opened this issue Sep 30, 2022 · 2 comments · Fixed by #5518
Closed
1 task done

DialogSizes no longer exported #5516

PaulSumner-Sage opened this issue Sep 30, 2022 · 2 comments · Fixed by #5518
Labels
Bug On Backlog released

Comments

@PaulSumner-Sage
Copy link
Contributor

Current behaviour

Previously: DialogSizes was accessible by MFEs to import and use as a type.
in v111.0.0 this is no longer the case

Expected behaviour

DialogSizes capable of being imported as a type into consuming code

CodeSandbox or Storybook URL

n/a

JIRA Ticket (Sage Only)

SBS-43091

Suggested Solution

node_modules/carbon-react/lib/components/dialog/dialog.component.d.ts

- declare type DialogSizes = "auto" | "extra-small" | "small" | "medium-small" | "medium" | "medium-large" | "large" | "extra-large";
+ export declare type DialogSizes = "auto" | "extra-small" | "small" | "medium-small" | "medium" | "medium-large" | "large" | "extra-large";

Carbon Version

v111.0.0

Design Tokens Version

No response

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@PaulSumner-Sage PaulSumner-Sage added Bug triage Triage Required labels Sep 30, 2022
@Parsium
Copy link
Contributor

Parsium commented Sep 30, 2022

FE-5390

@Parsium Parsium added On Backlog and removed triage Triage Required labels Sep 30, 2022
@Parsium Parsium mentioned this issue Sep 30, 2022
Merged
13 tasks
Parsium added a commit that referenced this issue Oct 7, 2022
@Parsium
feat(dialog): introduce DialogSizes type
97cf4c2 
closes #5516
Parsium added a commit that referenced this issue Oct 10, 2022
@Parsium
feat(dialog): introduce DialogSizes type
56b30ec 
closes #5516
Parsium added a commit that referenced this issue Oct 12, 2022
@Parsium
feat(dialog): introduce DialogSizes type
877f962 
closes #5516
Parsium added a commit that referenced this issue Oct 12, 2022
@Parsium
feat(dialog): introduce DialogSizes type
3facf23 
closes #5516
Parsium added a commit that referenced this issue Oct 13, 2022
@Parsium
feat(dialog): introduce DialogSizes type
872627c 
closes #5516
carbonci pushed a commit that referenced this issue Oct 14, 2022
@semantic-release-bot @carbonci
chore(release): 111.4.0
2d0dbf2 
## [111.4.0](v111.3.3...v111.4.0) (2022-10-14)

### Features

* **dialog:** introduce DialogSizes type ([872627c](872627c)), closes [#5516](#5516)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 111.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dialog): add DialogSizes type to component interface (FE-5390) Sage/carbon
3 participants
@Parsium @PaulSumner-Sage @carbonci