Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing padding overriding for MenuItem and IconButton #5640

Closed
1 task done
Sage-AlanYoung opened this issue Nov 24, 2022 · 2 comments · Fixed by #5665
Closed
1 task done

Allowing padding overriding for MenuItem and IconButton #5640

Sage-AlanYoung opened this issue Nov 24, 2022 · 2 comments · Fixed by #5665
Labels
Enhancement On Backlog released

Comments

@Sage-AlanYoung
Copy link

Sage-AlanYoung commented Nov 24, 2022 •
edited by mkrds
Loading

Desired behaviour

Allow the padding for MenuItem and IconButton components to be overridden and set to 0, if desired, as can be done with Button

Current behaviour

These components apply a default padding of 16, which may be undesirable

Suggested Solution

No response

CodeSandbox or Storybook URL

No response

Anything else we should know?

https://codesandbox.io/s/youthful-darwin-qtjnpk?file=/src/index.js

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@mkrds mkrds added On Backlog and removed triage Triage Required labels Nov 29, 2022
@mkrds
Copy link
Contributor

mkrds commented Nov 29, 2022

FE-5567

edleeks87 added a commit that referenced this issue Dec 1, 2022
@edleeks87
fix(menu-item): prevent default padding on button/anchor inside MenuI…
5d67b4d 
…tem if no onClick/href set

No longer sets the padding styling on the internal anchor or button elements rendered internally by
the `MenuItem` if both `onClick` and `href` props are not passed

fix #5640
@edleeks87 edleeks87 mentioned this issue Dec 1, 2022
Merged
9 tasks
edleeks87 added a commit that referenced this issue Dec 7, 2022
@edleeks87
fix(menu-item): prevent default padding on button/anchor inside MenuI…
d960642 
…tem if no onClick/href set

No longer sets the padding styling on the internal anchor or button elements rendered internally by
the `MenuItem` if both `onClick` and `href` props are not passed

fix #5640
edleeks87 added a commit that referenced this issue Dec 7, 2022
@edleeks87
fix(menu-item): prevent default padding on button/anchor inside MenuI…
45195c6 
…tem if no onClick/href set

No longer sets the padding styling on the internal anchor or button elements rendered internally by
the `MenuItem` if both `onClick` and `href` props are not passed

fix #5640
carbonci pushed a commit that referenced this issue Dec 14, 2022
@semantic-release-bot @carbonci
chore(release): 111.20.0
e8ed9b5 
## [111.20.0](v111.19.0...v111.20.0) (2022-12-14)

### Features

* **icon-button:** add padding interface to component ([2aba921](2aba921))

### Bug Fixes

* **menu-item:** prevent default padding on button/anchor inside MenuItem if no onClick/href set ([45195c6](45195c6)), closes [#5640](#5640)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 111.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sianford pushed a commit that referenced this issue Jan 4, 2023
@edleeks87 @sianford
fix(menu-item): prevent default padding on button/anchor inside MenuI…
af10e19 
…tem if no onClick/href set

No longer sets the padding styling on the internal anchor or button elements rendered internally by
the `MenuItem` if both `onClick` and `href` props are not passed

fix #5640
sianford pushed a commit that referenced this issue Jan 4, 2023
@semantic-release-bot @sianford
chore(release): 111.20.0
48081ce 
## [111.20.0](v111.19.0...v111.20.0) (2022-12-14)

### Features

* **icon-button:** add padding interface to component ([2aba921](2aba921))

### Bug Fixes

* **menu-item:** prevent default padding on button/anchor inside MenuItem if no onClick/href set ([45195c6](45195c6)), closes [#5640](#5640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(icon-button): add padding interface to component FE-5567 Sage/carbon
3 participants
@mkrds @carbonci @Sage-AlanYoung