fix(pager): fix bottom margin of number input when inside a form #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 242d29c:
|
Ensure the "current page" input field of Pager always has margin-bottom 0, even when inside a form. fix #5650
robinzigmond
force-pushed
the
FE-5565-second-fix
branch
from
a53613c to
242d29c
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Parsium
approved these changes
Dec 6, 2022
mkrds
approved these changes
Dec 6, 2022
divyajindel
approved these changes
Dec 6, 2022
|
🎉 This PR is included in version 111.13.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
DipperTheDan
added a commit
that referenced
this pull request
Apr 17, 2023
Link component was used as a button currenly does not supply the button with a type. This has caused a bug when `Pager` is used in a `Form`. The bug was causing the `onPrevious` callback function in `Pager` to be called in an onClick event when the enter key pressed. fixes #5676
14 tasks
carbonci
pushed a commit
that referenced
this pull request
Apr 20, 2023
### [117.7.1](v117.7.0...v117.7.1) (2023-04-20) ### Bug Fixes * **link:** ensure button has a type when used ([065c206](065c206)), closes [#5676](#5676)
|
🎉 This issue has been resolved in version 117.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the "current page" input field of Pager always has margin-bottom 0, even when inside a form.
Note - this is a fix for the change already merged from this PR, which doesn't always work due to CSS rules having the same specificity. This PR increases the specificity of the
margin-bottom: 0in Pager and adds a Cypress test to ensure the correct CSS is applies in the browser.fix #5650 (properly this time!)
Proposed behaviour
Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].