fix(pager): ensure there is no margin-bottom on page number input #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendered inside a Form component, the numberic input on Pager gets CSS rules to given it margin-bottom equal to the Form's field-spacing prop. In order to ensure the sub-components of Pager stay in line it always needs 0 margin-bottom, so a CSS rule has been added to set this, and made more specific that the one in Form. fix #5650
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7629ac7:
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Parsium
approved these changes
Nov 30, 2022
mkrds
approved these changes
Nov 30, 2022
divyajindel
approved these changes
Dec 5, 2022
|
🎉 This PR is included in version 111.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendered inside a Form component, the numeric input on Pager gets CSS rules to given it margin-bottom equal to the Form's field-spacing prop. In order to ensure the sub-components of Pager stay in line it always needs 0 margin-bottom, so a CSS rule has been added to set this, and made more specific that the one in Form.
fix #5650
Proposed behaviour
The number input on Pager should never have any bottom-margin, even when inside a Form.
Current behaviour
A Pager inside a Form is given bottom margin according to the Form's FieldSpacing prop (24px by default), causing it to not line up with the text.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].