Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatTableRowHeader with Button causes extra paddings #6561

Closed
1 task done
JinCoreana opened this issue Feb 1, 2024 · 4 comments · Fixed by #6766
Closed
1 task done

FlatTableRowHeader with Button causes extra paddings #6561

JinCoreana opened this issue Feb 1, 2024 · 4 comments · Fixed by #6766

Comments

@JinCoreana
Copy link
Contributor

JinCoreana commented Feb 1, 2024

Current behaviour

The default settings cause extra paddings within the cell,

      <FlatTableRowHeader stickyAlignment="right">
        <Button>Default</Button>
      </FlatTableRowHeader>
Screenshot 2024-02-01 at 11 27 07

With p={0} attribute, focus outline gets partially hidden

      <FlatTableRowHeader p={0} stickyAlignment="right">
        <Button>Padding 0</Button>
      </FlatTableRowHeader>
Screenshot 2024-02-01 at 11 28 58

Expected behaviour

When a Button is placed within a sticky cell, it should not result in additional padding, and the focus outline should be fully visible.
Screenshot 2024-02-01 at 11 29 45

CodeSandbox or Storybook URL

https://codesandbox.io/p/sandbox/table-padding-focus-kzm5nr

JIRA Ticket (Sage Only)

SBS-81079

Suggested Solution

No response

Carbon Version

124.6.0

Design Tokens Version

4.28.0

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@JinCoreana JinCoreana added Bug triage Triage Required labels Feb 1, 2024
@Parsium
Copy link
Contributor

Parsium commented Feb 6, 2024

Hi @JinCoreana 👋🏼 The sandbox link you have provided seems to redirect to an error page. Just so we have some more context on the design you are trying to produce, please could you recreate your code example using our new stackblitz template?

@JinCoreana
Copy link
Contributor Author

Hi @JinCoreana 👋🏼 The sandbox link you have provided seems to redirect to an error page. Just so we have some more context on the design you are trying to produce, please could you recreate your code example using our new stackblitz template?

Hi @Parsium No problem! here is the new link.
https://stackblitz.com/edit/parsium-carbon-starter-dmv1pi?file=src%2FApp.tsx

@nicktitchmarsh
Copy link
Contributor

FE-6373

@nicktitchmarsh nicktitchmarsh added On Backlog Squad Vortex and removed triage Triage Required labels Feb 13, 2024
mihai-albu-sage added a commit that referenced this issue Jul 2, 2024
…d rows

updated the flat table row header and the flat table cell to prevent covering the focus border

closes: #6561
mihai-albu-sage added a commit that referenced this issue Jul 3, 2024
…d rows

updated the flat table row header and the flat table cell to prevent covering the focus border

fixes: #6561
mihai-albu-sage added a commit that referenced this issue Jul 4, 2024
…d rows

updated the flat table row header and the flat table cell to prevent covering the focus border

fixes: #6561
mihai-albu-sage added a commit that referenced this issue Jul 4, 2024
…d rows

updated the flat table row header and the flat table cell to prevent covering the focus border

fixes: #6561
mihai-albu-sage added a commit that referenced this issue Jul 10, 2024
…d rows

updated the flat table row header and the flat table cell to prevent covering the focus border

fixes: #6561
carbonci pushed a commit that referenced this issue Jul 26, 2024
### [141.1.1](v141.1.0...v141.1.1) (2024-07-26)

### Bug Fixes

* **flat-table-row-header:** focus border partially covered in expanded rows ([d97caa8](d97caa8)), closes [#6561](#6561)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 141.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants