Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation summary unresponsive at 320px #6658

Closed
1 task done
niamhmadden24 opened this issue Apr 4, 2024 · 8 comments · Fixed by #6974
Closed
1 task done

Form validation summary unresponsive at 320px #6658

niamhmadden24 opened this issue Apr 4, 2024 · 8 comments · Fixed by #6974

Comments

@niamhmadden24
Copy link

Description

When I am using a small screen the form error validation isn't shown in full. I expect the full text to be visible on the page.

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-k3ccdw?file=src%2FApp.tsx

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

No response

Suggested solution

No response

Carbon version

125.12.1

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@niamhmadden24 niamhmadden24 added Bug triage Triage Required labels Apr 4, 2024
@edleeks87
Copy link
Contributor

edleeks87 commented Apr 4, 2024

@harpalsingh are you okay with us updating the summary to wrap in the above scenario or is there a steer to use a different component/ pattern here?

@harpalsingh
Copy link
Member

@edleeks87 Makes sense, let me mockup the design with it shown and Ill run it by DS too. I'll add to this issue once ready

@edleeks87 edleeks87 changed the title Form validation unresponsive at 320px Form validation summary unresponsive at 320px Apr 9, 2024
@Parsium
Copy link
Contributor

Parsium commented Apr 30, 2024

Any updates on this @harpalsingh? 😄

@edleeks87
Copy link
Contributor

Paging Dr. @harpalsingh

@DipperTheDan
Copy link
Contributor

@harpalsingh - just tagging you so you know we need a response on this please. Thank you 😄

@harpalsingh
Copy link
Member

@Parsium @DipperTheDan I have designs on making this responsive and will create a ticket for it.

@edleeks87
Copy link
Contributor

FE-6721

@edleeks87 edleeks87 added On Backlog and removed Requires Designs triage Triage Required labels Jul 25, 2024
nuria1110 added a commit that referenced this issue Sep 20, 2024
This fix allows the form-footer content to be responsive, the buttons and validation message will
wrap in smaller screen sizes. When buttons are `fullWidth` the `rightSideButtons` will now render
underneath the `saveButton` instead of above.

fix #6658
nuria1110 added a commit that referenced this issue Sep 20, 2024
This fix allows the form-footer content to be responsive, the buttons and validation message will
wrap in smaller screen sizes. When buttons are `fullWidth` the `rightSideButtons` will now render
underneath the `saveButton` instead of above.

fix #6658
nuria1110 added a commit that referenced this issue Sep 20, 2024
This fix allows the form-footer content to be responsive, the buttons and validation message will
wrap in smaller screen sizes. When buttons are `fullWidth` the `rightSideButtons` will now render
underneath the `saveButton` instead of above.

fix #6658
nuria1110 added a commit that referenced this issue Sep 25, 2024
This fix allows the form-footer content to be responsive, the buttons and validation message will
wrap in smaller screen sizes. When buttons are `fullWidth` the `rightSideButtons` will now render
underneath the `saveButton` instead of above.

fix #6658
carbonci pushed a commit that referenced this issue Oct 3, 2024
### [142.13.1](v142.13.0...v142.13.1) (2024-10-03)

### Bug Fixes

* **form:** allow form-footer content to be responsive ([c7d55e1](c7d55e1)), closes [#6658](#6658)
@carbonci
Copy link
Collaborator

carbonci commented Oct 3, 2024

🎉 This issue has been resolved in version 142.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

7 participants