Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader spinner - custom text should be one line and centered #6702

Closed
1 task done
gusch opened this issue Apr 29, 2024 · 2 comments · Fixed by #6710
Closed
1 task done

Loader spinner - custom text should be one line and centered #6702

gusch opened this issue Apr 29, 2024 · 2 comments · Fixed by #6710

Comments

@gusch
Copy link
Contributor

gusch commented Apr 29, 2024

Description

If i override the label of a Loader Spinner with a long text, it is left align and truncated to take the width of the spinner

image

Suggested solution

The text should be centered on one line.

image

Demo URL

No response

Alternatives

No response

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@gusch gusch added Enhancement triage Triage Required labels Apr 29, 2024
@Parsium
Copy link
Contributor

Parsium commented Apr 30, 2024

FE-6539

@Parsium Parsium added On Backlog and removed triage Triage Required labels Apr 30, 2024
tomdavies73 added a commit that referenced this issue May 2, 2024
… svg wrapper

removes the fixed width on the components svg wrapper and label to ensure the component
centers when rendered. Due to these changes the components label can now extend longer
than the svg wrappers width. A varied margin-top is also now applied to the label on
all sizes above extra-small, to ensure there is a correct amount of space between the
label and svg wrapper. Finally, the labels text has also now been aligned to the center,
so if any text does wrap due to container constraints, it will center correctly

fix #6702
carbonci pushed a commit that referenced this issue May 9, 2024
### [134.0.3](v134.0.2...v134.0.3) (2024-05-09)

### Bug Fixes

* **loader-spinner:** allow components label to extend longer than the svg wrapper ([bd87c52](bd87c52)), closes [#6702](#6702)
@carbonci
Copy link
Collaborator

carbonci commented May 9, 2024

🎉 This issue has been resolved in version 134.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants