Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border appearing for buttons within MenuItem #6725

Closed
1 task done
johnb-sage opened this issue May 8, 2024 · 2 comments · Fixed by #6727
Closed
1 task done

Border appearing for buttons within MenuItem #6725

johnb-sage opened this issue May 8, 2024 · 2 comments · Fixed by #6727

Comments

@johnb-sage
Copy link

Description

v129.0.0 introduced a change to button styles where a button rendered within a MenuItem now has a border and additional padding.

Screen.Recording.2024-05-07.at.13.53.21.mov

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-wwtgen?file=src%2FApp.tsx

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

SBS-85541

Suggested solution

No response

Carbon version

134.0.0

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@johnb-sage johnb-sage added Bug triage Triage Required labels May 8, 2024
@edleeks87
Copy link
Contributor

FE-6573

@edleeks87 edleeks87 added On Backlog and removed triage Triage Required labels May 8, 2024
edleeks87 added a commit that referenced this issue May 8, 2024
…-container renders in menu

Update `Link` (which are rendered as part of MenuItem) styling is  applied to any open button
rendered when `PopoverContainer` is a child of a `MenuItem`

fix #6725
carbonci pushed a commit that referenced this issue May 8, 2024
### [134.0.2](v134.0.1...v134.0.2) (2024-05-08)

### Bug Fixes

* **link:** ensure styling overrides apply to open button when popover-container renders in menu ([4b9ea02](4b9ea02)), closes [#6725](#6725)
@carbonci
Copy link
Collaborator

carbonci commented May 8, 2024

🎉 This issue has been resolved in version 134.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants