Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge appears under MultiActionButton #6765

Closed
1 task done
ernon66 opened this issue Jun 6, 2024 · 3 comments · Fixed by #7012
Closed
1 task done

Badge appears under MultiActionButton #6765

ernon66 opened this issue Jun 6, 2024 · 3 comments · Fixed by #7012

Comments

@ernon66
Copy link

ernon66 commented Jun 6, 2024

Description

Hello,

The Badge component interacts differently with a MultiActionButton than it does with a regular Button

With a Button the Badge appears correctly over it
With a MultiActionButton the Badge appears under it

image

I think it should always appear over the component

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-2zetxs?file=src%2FApp.tsx

Steps to reproduce

Use a Badge component with a MultiActionButton

JIRA ticket numbers (Sage only)

SBS-99460

Suggested solution

I have not found any workaround

Carbon version

136.0.3

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@ernon66 ernon66 added Bug triage Triage Required labels Jun 6, 2024
@edleeks87
Copy link
Contributor

Should be a simple fix:

<StyledBadgeWrapper>
      {renderCorrectBadge()}
      {children}
    </StyledBadgeWrapper>

needs to be

<StyledBadgeWrapper>
      {children}
      {renderCorrectBadge()}
    </StyledBadgeWrapper>

@DipperTheDan
Copy link
Contributor

FE-6665

@DipperTheDan DipperTheDan added On Backlog Squad Petrus and removed triage Triage Required labels Jun 11, 2024
nuria1110 added a commit that referenced this issue Oct 10, 2024
This fix ensures badge does not appear under child components.

fix #6765
nuria1110 added a commit that referenced this issue Oct 10, 2024
This fix ensures badge does not appear under child components.

fix #6765
nuria1110 added a commit that referenced this issue Oct 15, 2024
This fix ensures badge does not appear under child components.

fix #6765
nuria1110 added a commit that referenced this issue Oct 15, 2024
This fix ensures badge does not appear under child components.

fix #6765
carbonci pushed a commit that referenced this issue Oct 16, 2024
### [143.2.1](v143.2.0...v143.2.1) (2024-10-16)

### Bug Fixes

* **badge:** ensure badge does not appear under child components ([d88d3ec](d88d3ec)), closes [#6765](#6765)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 143.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants