Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select component does not expand to show all of singular-item multi-line content #6939

Closed
1 task done
PaulSumner-Sage opened this issue Sep 9, 2024 · 2 comments · Fixed by #7001
Closed
1 task done

Select component does not expand to show all of singular-item multi-line content #6939

PaulSumner-Sage opened this issue Sep 9, 2024 · 2 comments · Fixed by #7001
Labels
Bug On Backlog released Squad Nebula

Comments

@PaulSumner-Sage
Copy link
Contributor

Description

We have multiple locations in our code where a multiple-line message is given: or just that in one language it becomes longer and multi-line. If a Box is used to provide a singular React node component child: the Select option is only the height of a singular line and does not expand to fit the content given: requiring a scrollbar to be used.

When these components were first written (years ago): this worked as expected.

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-4wxr6b?file=src%2FApp.tsx

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

SBS-108085

Suggested solution

No response

Carbon version

"latest" in stackblitz"

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@PaulSumner-Sage PaulSumner-Sage added Bug triage Triage Required labels Sep 9, 2024
@nineteen88
Copy link
Contributor

FE-6799

@nineteen88 nineteen88 added Squad Nebula On Backlog and removed triage Triage Required labels Sep 10, 2024
edleeks87 added a commit that referenced this issue Oct 4, 2024
@edleeks87
fix(select): ensure that select list sets height relative to custom o…
de642dc 
…ption

Ensures that SelectList height is set relatively when a custom option is passed as child so that
there is no overflow

fix #6939
edleeks87 added a commit that referenced this issue Oct 4, 2024
@edleeks87
fix(option): makes value and text props optional
7cb406f 
Updates Option interface to allow `value` and `text` to be optional to allow users
to compose `children` for complex layouts. This ensures that `SelectList` height
is set relatively when a custom option is passed as child so that there is no
overflow

fix #6939
edleeks87 added a commit that referenced this issue Oct 4, 2024
@edleeks87
fix(option): makes value and text props optional
47091dc 
Updates Option interface to allow `value` and `text` to be optional to allow users
to compose `children` for complex layouts. This ensures that `SelectList` height
is set relatively when a custom option is passed as child so that there is no
overflow

fix #6939
@edleeks87 edleeks87 mentioned this issue Oct 4, 2024
Merged
9 tasks
edleeks87 added a commit that referenced this issue Oct 4, 2024
@edleeks87
fix(option): makes value and text props optional
69a086d 
Updates Option interface to allow `value` and `text` to be optional to allow users
to compose `children` for complex layouts. This ensures that `SelectList` height
is set relatively when a custom option is passed as child so that there is no
overflow

fix #6939
edleeks87 added a commit that referenced this issue Oct 8, 2024
@edleeks87
fix(option): makes value and text props optional
790f388 
Updates Option interface to allow `value` and `text` to be optional to allow users
to compose `children` for complex layouts. This ensures that `SelectList` height
is set relatively when a custom option is passed as child so that there is no
overflow

fix #6939
edleeks87 added a commit that referenced this issue Oct 9, 2024
@edleeks87
fix(option): makes value and text props optional
8eaded4 
Updates Option interface to allow `value` and `text` to be optional to allow users
to compose `children` for complex layouts. This ensures that `SelectList` height
is set relatively when a custom option is passed as child so that there is no
overflow

fix #6939
carbonci pushed a commit that referenced this issue Oct 14, 2024
@semantic-release-bot @carbonci
chore(release): 143.0.1
de26679 
### [143.0.1](v143.0.0...v143.0.1) (2024-10-14)

### Bug Fixes

* **option:** makes `value` and `text` props optional ([fb37215](fb37215)), closes [#6939](#6939)
* **select:** upgrade tanstack react-virtual to latest ([c51688f](c51688f)), closes [#6978](#6978)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 143.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released Squad Nebula
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Select virtualiser tweaks Sage/carbon
3 participants
@PaulSumner-Sage @carbonci @nineteen88