Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Action Button still not always working for screenreader despite being tabbable - serious #7054

Closed
1 task done
adamfsage opened this issue Nov 4, 2024 · 3 comments · Fixed by #7074
Closed
1 task done

Comments

@adamfsage
Copy link

adamfsage commented Nov 4, 2024

Description

When I click on dynamic shortcut button in home.ui (eg. Go to Accounting, Go to Payroll...) with a screenreader, it should focus on the options instead of ignoring it and going through the rest of the DOM.

Similar to this issue here, I have tried on updated carbon but this still does not work despite being tabbable

Screen.Recording.2024-11-04.at.12.36.35.mov

Reproduction

https://carbon.sage.com/?path=/story/multi-action-button--button-types

Steps to reproduce

Open screenreader, select multi-action button, click to open and then go to next element

JIRA ticket numbers (Sage only)

SBS-113601

Suggested solution

No response

Carbon version

144.4.0

Design tokens version

4.34.0

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@adamfsage adamfsage added Bug triage Triage Required labels Nov 4, 2024
@adamfsage adamfsage changed the title Multi Action Button still not always working for screenreader despite being tabbable Multi Action Button still not always working for screenreader despite being tabbable - serious Nov 4, 2024
@hrrcox
Copy link

hrrcox commented Nov 4, 2024

Using VoiceOver in Safari, select multi action button with VO commands (ctrl+option) + Space, expected behaviour would be that button popover opens and focus is taken to the popover. VO+left would then move through the child items within the popover.

Current behaviour is that VO+space opens the popover, but unable to reach child items using VO+left, moves onto next item beyond the popover.

Tested on Carbon V144.4.0 in Safari with VO and in Firefox with NVDA

@nicktitchmarsh
Copy link
Contributor

FE-6890

nuria1110 added a commit that referenced this issue Nov 13, 2024
… can navigate menu popup

Fixes issue where screen reader users using VoiceOver could not navigate into the menu buttons using
commands VO+Space to open the menu then VO+right to navigate. The first option will now gain focus
on open using any interaction method, including onClick, keyboard navigation and screen reader
controls.

fix #7054
nuria1110 added a commit that referenced this issue Nov 13, 2024
… can navigate menu popup

Fixes issue where screen reader users using VoiceOver could not navigate into the menu buttons using
commands VO+Space to open the menu then VO+right to navigate. The first option will now gain focus
on open using any interaction method, including onClick, keyboard navigation and screen reader
controls.

fix #7054
nuria1110 added a commit that referenced this issue Nov 14, 2024
… can navigate menu popup

Fixes issue where screen reader users using VoiceOver could not navigate into the menu buttons using
commands VO+Space to open the menu then VO+right to navigate. The first option will now gain focus
on open using any interaction method, including onClick, keyboard navigation and screen reader
controls.

fix #7054
nuria1110 added a commit that referenced this issue Nov 14, 2024
… can navigate menu popup

Fixes issue where screen reader users using VoiceOver could not navigate into the menu buttons using
commands VO+Space to open the menu then VO+right to navigate. The first option will now gain focus
on open using any interaction method, including onClick, keyboard navigation and screen reader
controls.

fix #7054
carbonci pushed a commit that referenced this issue Dec 2, 2024
### [144.9.11](v144.9.10...v144.9.11) (2024-12-02)

### Bug Fixes

* **multi-action-button, split-button:** ensure screen reader commands can navigate menu popup ([26e142a](26e142a)), closes [#7054](#7054)
@carbonci
Copy link
Collaborator

carbonci commented Dec 2, 2024

🎉 This issue has been resolved in version 144.9.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants