Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ActionPopover] - Add aria-describedby support for menu button #7107

Closed
1 task done
MarcServat opened this issue Nov 28, 2024 · 2 comments · Fixed by #7115
Closed
1 task done

[ActionPopover] - Add aria-describedby support for menu button #7107

MarcServat opened this issue Nov 28, 2024 · 2 comments · Fixed by #7115
Labels
Enhancement On Backlog released

Comments

@MarcServat
Copy link
Contributor

Description

When using Action Popover default button or an IconButton component to open the menu, it can require to attach a text to provide context. Adding support for aria-describedby will provide the option to link the button to a descriptive text.

Suggested solution

Adding support for aria-describedby

Demo URL

No response

Alternatives

No response

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@MarcServat MarcServat added Enhancement triage Triage Required labels Nov 28, 2024
@tomdavies73
Copy link
Contributor

FE-7105

@tomdavies73 tomdavies73 added On Backlog and removed triage Triage Required labels Dec 3, 2024
nuria1110 added a commit that referenced this issue Dec 5, 2024
@nuria1110
feat(action-popover): add aria-labelledby and aria-describedby props
d4662fb 
fix #7107
@nuria1110 nuria1110 mentioned this issue Dec 5, 2024
Merged
14 tasks
nuria1110 added a commit that referenced this issue Dec 5, 2024
@nuria1110
feat(action-popover): add aria-labelledby and aria-describedby props
5ea9dd6 
fix #7107
nuria1110 added a commit that referenced this issue Dec 5, 2024
@nuria1110
feat(action-popover): add aria-labelledby and aria-describedby props
48552f1 
fix #7107
carbonci pushed a commit that referenced this issue Dec 11, 2024
@semantic-release-bot @carbonci
chore(release): 144.19.0
ab6ec24 
## [144.19.0](v144.18.0...v144.19.0) (2024-12-11)

### Features

* **action-popover:** add aria-labelledby and aria-describedby props ([6267cb5](6267cb5)), closes [#7107](#7107)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 144.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

tomdavies73 pushed a commit that referenced this issue Dec 12, 2024
@semantic-release-bot @tomdavies73
chore(release): 144.19.0
f30a92c 
## [144.19.0](v144.18.0...v144.19.0) (2024-12-11)

### Features

* **action-popover:** add aria-labelledby and aria-describedby props ([6267cb5](6267cb5)), closes [#7107](#7107)
tomdavies73 pushed a commit that referenced this issue Dec 12, 2024
@semantic-release-bot @tomdavies73
chore(release): 144.19.0
78538c5 
## [144.19.0](v144.18.0...v144.19.0) (2024-12-11)

### Features

* **action-popover:** add aria-labelledby and aria-describedby props ([6267cb5](6267cb5)), closes [#7107](#7107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(action-popover): add aria-labelledby and aria-describedby props Sage/carbon
3 participants
@MarcServat @carbonci @tomdavies73