Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backgroundColor has no effect on DismissibleBox #7108

Closed
1 task done
nokSage opened this issue Nov 29, 2024 · 2 comments
Closed
1 task done

backgroundColor has no effect on DismissibleBox #7108

nokSage opened this issue Nov 29, 2024 · 2 comments

Comments

@nokSage
Copy link

nokSage commented Nov 29, 2024

Description

The backgroundColor prop has no effect on DismissibleBox. It looks like that it is accidentally exposed because normally one would prefer to use the variant prop to control the background colour instead.

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-2jcuzf?file=src%2FApp.tsx

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

No response

Suggested solution

Remove backgroundColor from TS props definition and documentation for the DismissibleBox component

Carbon version

144.9.3

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@nokSage nokSage added Bug triage Triage Required labels Nov 29, 2024
@tomdavies73
Copy link
Contributor

FE-7016

@tomdavies73 tomdavies73 added On Backlog and removed triage Triage Required labels Dec 3, 2024
carbonci pushed a commit that referenced this issue Dec 17, 2024
## [145.0.0](v144.22.1...v145.0.0) (2024-12-17)

### ⚠ BREAKING CHANGES

* The `roundedCornersOptOut` feature flag has been removed completely. If passed to
the `CarbonProvider` it will need to be removed, if consumers are also relying on previous
non-rounded corners styling this will also no longer be available.

### Features

* remove roundedCornersOptOut feature flag ([a21e2b9](a21e2b9))

### Bug Fixes

* **dismissible-box:** remove background color props from type interface ([882d28c](882d28c)), closes [#7108](#7108)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 145.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants