Remove react test renderer from I18n Specs #1532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjtait
approved these changes
Sep 6, 2017
|
Fixes #1445 |
abramin
suggested changes
Sep 7, 2017
src/components/i18n/__spec__.js
Outdated
| const output = shallowRenderer.getRenderOutput(); | ||
| expect(output.type).toEqual('span'); | ||
| expect(output.props.children).toEqual('bar'); | ||
| describe('when component is rendered with only a key', () => { |
There was a problem hiding this comment.
Should this be scope? Can't see anything called key
src/components/i18n/__spec__.js
Outdated
| expect(output.type).toEqual('div'); | ||
| expect(output.props.children).toEqual('bar'); | ||
| describe('when component is rendered with inline set to false', () => { | ||
| it('renders the value of the key in a div', () => { |
abramin
approved these changes
Sep 22, 2017
|
This seems to be adding Perhaps moment needs updating and react-addons? |
SeanArmstrong
added
Pending Review
and removed
Passed Review
Passed Review (2/2)
labels
SeanArmstrong
changed the title
abramin
approved these changes
Sep 26, 2017
ianoxley
suggested changes
Oct 3, 2017
| __html: 'something <strong>bold</strong>' | ||
| describe('when component is rendered inline', () => { | ||
| it('renders the parsed markdown in a span', () => { | ||
| spyOn(i18n, 't').and.returnValue('something __bold__'); |
| __html: '<p>something <strong>bold</strong></p>\n' | ||
| describe('when component is rendered as a block', () => { | ||
| it('renders the parsed markdown in a div', () => { | ||
| spyOn(i18n, 't').and.returnValue('something __bold__'); |
| __html: 'some <span>html</span>' | ||
| describe('when component is rendered with html in the value', () => { | ||
| it('parses the html correctly', () => { | ||
| spyOn(i18n, 't').and.returnValue('some <span>html</span>'); |
andrewjtait
reviewed
Oct 18, 2017
| "fbjs": "0.8.15", | ||
| "object-assign": "4.1.1" | ||
| } | ||
| }, |
There was a problem hiding this comment.
should this be re-added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React test renderer was just used for shallow rendering of I18n specs. These specs have been refactored to use enzyme/snapshot testing
Snapshot tests need to be triple checked before merging.
NOTE: Module has been re-added as it is required by enzyme - enzymejs/enzyme#875