-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grid): add responsive grid component #2668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamime
reviewed
Feb 24, 2020
ian-forster
force-pushed
the
FE-1650-responsive-grid
branch
from
February 25, 2020 10:50
95e3138
to
11879ab
Compare
ian-forster
force-pushed
the
FE-1650-responsive-grid
branch
from
February 27, 2020 09:39
c05a12c
to
1477080
Compare
damianOfKyan
previously approved these changes
Feb 27, 2020
jamime
suggested changes
Feb 28, 2020
damianOfKyan
previously approved these changes
Mar 3, 2020
jamime
previously approved these changes
Mar 3, 2020
ian-forster
force-pushed
the
FE-1650-responsive-grid
branch
from
March 9, 2020 11:58
fdd5e22
to
b267036
Compare
damianOfKyan
previously approved these changes
Mar 9, 2020
ian-forster
force-pushed
the
FE-1650-responsive-grid
branch
from
March 12, 2020 14:16
3c1f2a7
to
abdd747
Compare
KatarzynaQA
reviewed
Mar 16, 2020
KatarzynaQA
previously approved these changes
Mar 16, 2020
ian-forster
force-pushed
the
FE-1650-responsive-grid
branch
from
March 16, 2020 14:47
5b4cfd9
to
b58949e
Compare
ian-forster
force-pushed
the
FE-1650-responsive-grid
branch
from
March 16, 2020 15:35
b58949e
to
cd2999a
Compare
damianOfKyan
previously approved these changes
Mar 16, 2020
ian-forster
force-pushed
the
FE-1650-responsive-grid
branch
from
March 16, 2020 15:40
cd2999a
to
62e76c5
Compare
damianOfKyan
approved these changes
Mar 16, 2020
jamime
suggested changes
Mar 16, 2020
jamime
approved these changes
Mar 17, 2020
KatarzynaQA
approved these changes
Mar 17, 2020
DlgSHi
approved these changes
Mar 18, 2020
🎉 This PR is included in version 14.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
This Grid Component delivers the responsive grid as specified in the RFC
Current behaviour
Before this component was added Carbon did not provide a responsive layout component.
Checklist
d.ts
file added or updatedTesting instructions
Follow the instructions in the mdx file to see how the Grid behaves at different given widths.