fix(flat-table-cell, flat-table-header): raise specificity of spacing styles FE-3838 #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6827513:
|
edleeks87
force-pushed
the
FE-3838-cell-width-and-truncate
branch
from
fa8eba0 to
88fb78c
Compare
DipperTheDan
reviewed
Apr 6, 2021
bulaj
previously approved these changes
Apr 7, 2021
|
Combining expandable rows with truncate doesn't actually truncate the content of the main row. Seems to work for sub rows however. |
edleeks87
force-pushed
the
FE-3838-cell-width-and-truncate
branch
2 times, most recently
from
09318db to
4227e80
Compare
nicktitchmarsh
previously approved these changes
Apr 8, 2021
edleeks87
force-pushed
the
FE-3838-cell-width-and-truncate
branch
from
4227e80 to
f2bc672
Compare
nicktitchmarsh
previously approved these changes
Apr 8, 2021
DipperTheDan
approved these changes
Apr 8, 2021
DipperTheDan
previously approved these changes
Apr 8, 2021
bulaj
previously approved these changes
Apr 8, 2021
… styles Raises specificity of the `space` styles applied to div container within `FlatTableCell` and `FlatTableHeader` so any values passed via `styled-system` props take precedence of the cell-sizes configs fix #3846
… cell and new truncate styling Adds `width` prop for `FlatTableCell`. Adds `truncate` and `title` props to support styling content that overflows the width of the column and overriding the text displayed when the mouse hovers over a cell.
edleeks87
dismissed stale reviews from bulaj, DipperTheDan, and nicktitchmarsh
via
86b42b8
edleeks87
force-pushed
the
FE-3838-cell-width-and-truncate
branch
from
f2bc672 to
86b42b8
Compare
DipperTheDan
approved these changes
Apr 13, 2021
ZhuoyuJin
approved these changes
Apr 13, 2021
|
🎉 This PR is included in version 68.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3846
Proposed behaviour
Raises specificity of the
spacestyles applied to div container withinFlatTableCell,FlatTableRowHeaderandFlatTableHeaderso any values passed viastyled-systemprops take precedence of the cell-sizesconfigs
Adds
widthprop forFlatTableCell. Addstruncateandtitleprops to support styling contentthat overflows the width of the column and overriding the text displayed when the mouse hovers over
a cell.
After speaking to @harpalsingh it was decided to remove the
nowrapstyling on cells and only apply it whentruncateis trueCurrent behaviour
Styled-system props are overridden by the size config
No ability to truncate cell content
Checklist
d.tsfile added or updated if requiredAdditional context
Testing instructions
design-system-flat-table--with-truncated-cell-contenthas been createdhttps://codesandbox.io/s/carbon-quickstart-forked-fm951?file=/src/index.js