Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(multi-select): hide select list on blur #3877

Merged
merged 4 commits into from
Apr 13, 2021
Merged

refactor(multi-select): hide select list on blur #3877

merged 4 commits into from
Apr 13, 2021

Conversation

mmaciorowski-sage
Copy link

@mmaciorowski-sage mmaciorowski-sage commented Apr 6, 2021 •
edited
Loading

Proposed behaviour

Hide menu on blur

Current behaviour

Menu like Select or FilterableSelect stays open when the tab is changed
https://codesandbox.io/s/dazzling-roentgen-snkff?fontsize=14&hidenavigation=1&theme=dark

Checklist

  • Commits follow our style guide
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Cypress automation tests added or updated if required
  • Storybook added or updated if required
  • Typescript d.ts file added or updated if required
  • Carbon implementation and Design System documentation are congruent

Additional context

Fixes: #3833

Testing instructions

https://codesandbox.io/s/carbon-quickstart-forked-lhcqp?file=/src/index.js

@mmaciorowski-sage mmaciorowski-sage self-assigned this Apr 6, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a26f656:

Sandbox Source
carbon-quickstart Configuration
gifted-austin-owblv PR
carbon-quickstart (forked) PR
divine-morning-dclld Issue #3833
infallible-jones-1o1ct Issue #3833

@edleeks87
Copy link
Contributor

edleeks87 commented Apr 7, 2021 •
edited
Loading

Hey @customcodepl I tried reproducing the issue in a sandbox and it doesn't seem to have quite fixed it , I think the issue might be across all the select variants

https://codesandbox.io/s/carbon-quickstart-forked-dtjil?file=/src/index.js

@mmaciorowski-sage
Copy link
Author

mmaciorowski-sage commented Apr 7, 2021 •
edited
Loading

Hey @customcodepl I tried reproducing the issue in a sandbox and it doesn't seem to have quite fixed it

https://codesandbox.io/s/carbon-quickstart-forked-dtjil?file=/src/index.js

Hi Ed, you are right. It's still in progress. I'll fix it.

--
Hi @edleeks87, fixed please feel free to test it: https://codesandbox.io/s/carbon-quickstart-forked-eb23q?file=/src/index.js

@mmaciorowski-sage mmaciorowski-sage force-pushed the FE-3965-filterable-select-in-tab-doesn-t-close-dropdown-when-it-loses-focus branch from 51b7330 to 1dbd12b Compare April 7, 2021 09:40
dawidzarzycki
dawidzarzycki previously approved these changes Apr 7, 2021
View reviewed changes
@edleeks87
Copy link
Contributor

edleeks87 commented Apr 9, 2021 •
edited
Loading

@customcodepl can you add it for SimpleSelect as well please and tag this issue (#3833) as fixed when you do

https://codesandbox.io/s/carbon-quickstart-forked-c6u8u?file=/src/index.js:698-710

@mmaciorowski-sage mmaciorowski-sage force-pushed the FE-3965-filterable-select-in-tab-doesn-t-close-dropdown-when-it-loses-focus branch from 1dbd12b to c419e23 Compare April 9, 2021 08:59
edleeks87
edleeks87 previously approved these changes Apr 9, 2021
View reviewed changes
@mmaciorowski-sage mmaciorowski-sage requested a review from DlgSHi April 9, 2021 13:21
dawidzarzycki
dawidzarzycki previously approved these changes Apr 9, 2021
View reviewed changes
@KatarzynaQA KatarzynaQA dismissed stale reviews from dawidzarzycki and edleeks87 via 66b15a6 April 12, 2021 09:46
DlgSHi
DlgSHi previously approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@DlgSHi DlgSHi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for cypress tests

edleeks87
edleeks87 previously approved these changes Apr 13, 2021
View reviewed changes
dawidzarzycki
dawidzarzycki previously approved these changes Apr 13, 2021
View reviewed changes
@mmaciorowski-sage mmaciorowski-sage marked this pull request as ready for review April 13, 2021 08:49
@mmaciorowski-sage mmaciorowski-sage requested review from a team as code owners April 13, 2021 08:49
@mmaciorowski-sage mmaciorowski-sage force-pushed the FE-3965-filterable-select-in-tab-doesn-t-close-dropdown-when-it-loses-focus branch from 3edd64e to 44a62d9 Compare April 13, 2021 11:00
@DlgSHi DlgSHi self-requested a review April 13, 2021 11:07
@grabkowski grabkowski merged commit fbd7d88 into master Apr 13, 2021
@grabkowski grabkowski deleted the FE-3965-filterable-select-in-tab-doesn-t-close-dropdown-when-it-loses-focus branch April 13, 2021 13:07
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 68.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawidzarzycki dawidzarzycki dawidzarzycki approved these changes

@DlgSHi DlgSHi DlgSHi approved these changes

@edleeks87 edleeks87 edleeks87 approved these changes

Assignees

@mmaciorowski-sage mmaciorowski-sage

Labels
No UX QA Required Passed QA Passed Review released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs: Menu like Select or FilterableSelect stays open when the tab is changed
7 participants
@mmaciorowski-sage @edleeks87 @carbonci @dawidzarzycki @DlgSHi @grabkowski @KatarzynaQA