Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profile): add styled-system margin props - FE-3568 #3890

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

DipperTheDan
Copy link
Contributor

@DipperTheDan DipperTheDan commented Apr 9, 2021

Proposed behaviour

Adds styled-system margin props to the Profile component

Current behaviour

Profile component currently does not have access to the styled-system props

Checklist

  • Commits follow our style guide
    - [ ] Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
    - [ ] Cypress automation tests added or updated if required
  • Storybook added or updated if required
    - [ ] Typescript d.ts file added or updated if required
  • Carbon implementation and Design System documentation are congruent

Additional context

N/A

Testing instructions

https://codesandbox.io/s/reverent-elgamal-7mfrf

  • apply the styled-system margin props to the Profile component. Styles should behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b834dee:

Sandbox Source
carbon-quickstart Configuration
sad-butterfly-l7pf1 PR

@samtjo samtjo marked this pull request as ready for review April 12, 2021 09:42
@samtjo samtjo requested review from a team as code owners April 12, 2021 09:42
@DipperTheDan DipperTheDan merged commit 6fe7062 into master Apr 12, 2021
@DipperTheDan DipperTheDan deleted the FE-3568-styled_system_profile branch April 12, 2021 13:07
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 68.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants