docs(row and column): add a link to grid component in deprecation warning #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrds
approved these changes
Apr 13, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0dfce65:
|
samtjo
approved these changes
Apr 13, 2021
samtjo
approved these changes
Apr 13, 2021
|
🎉 This PR is included in version 68.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Adds a link to the
Gridcomponent in the deprecation warning for Row and Column.Current behaviour
No link to component provided. User will have to manually search for the
Gridcomponent.Checklist
- [ ] Screenshots are included in the PR if useful- [ ] Unit tests added or updated if required- [ ] Cypress automation tests added or updated if required- [ ] Typescriptd.tsfile added or updated if requiredAdditional context
Testing instructions
Click on the word
Gridin the deprecation warning in theRowMDX example. You should be taken to theGriddocumentation.