fix(flat-table-row): add support for controlling expanded rows externally FE-4007 #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edleeks87
force-pushed
the
FE-4007-controlled-expansion
branch
from
b09b773 to
2402df1
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 721f975:
|
DipperTheDan
previously approved these changes
Apr 15, 2021
dawidzarzycki
previously approved these changes
Apr 19, 2021
DlgSHi
reviewed
Apr 19, 2021
| ### Controlled | ||
|
|
||
| <Preview> | ||
| <Story name="controlled"> |
There was a problem hiding this comment.
We need to ignore this story in chromatic and add cypress test for that purpose because the only one way to check if it works properly
ZhuoyuJin
dismissed stale reviews from dawidzarzycki and DipperTheDan
via
0eb1a38
sianford
reviewed
Apr 21, 2021
| Scenario: You can expand all rows by clicking on Expand All | ||
| Given I open "Design System Flat Table Expandable" component page "controlled" in no iframe | ||
| And I click "Collapse All" button on preview |
There was a problem hiding this comment.
Please remove extra space between And and I.
edleeks87
force-pushed
the
FE-4007-controlled-expansion
branch
from
aa11df2 to
57522d2
Compare
…ally Adds `useEffect` to ensure `expandable` `FlatTableRows` update when the value of the `expanded` prop changes fix #3875
edleeks87
force-pushed
the
FE-4007-controlled-expansion
branch
from
57522d2 to
721f975
Compare
sianford
approved these changes
Apr 21, 2021
KatarzynaQA
approved these changes
Apr 22, 2021
dawidzarzycki
approved these changes
Apr 22, 2021
DipperTheDan
approved these changes
Apr 22, 2021
|
🎉 This PR is included in version 68.25.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3875
Proposed behaviour
Adds
useEffectto ensureexpandableFlatTableRowsupdate when the value of theexpandedpropchanges
Current behaviour
expandablefunctionality cannot be controlled externallyChecklist
d.tsfile added or updated if requiredAdditional context
Testing instructions
design-system-flat-table-expandable--controlledaddedhttps://codesandbox.io/s/nice-almeida-j22d6