feat(click-away-wrapper): add ClickAwayWrapper component to internal directory #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c38e7f:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
edleeks87
force-pushed
the
click-away-wrapper
branch
2 times, most recently
from
cd23fa4 to
cb1c4e1
Compare
Parsium
previously approved these changes
May 31, 2022
DipperTheDan
requested changes
Jun 6, 2022
src/__internal__/click-away-wrapper/click-away-wrapper.spec.tsx
Outdated
Show resolved
Hide resolved
DipperTheDan
previously approved these changes
Jun 6, 2022
Parsium
previously approved these changes
Jun 6, 2022
edleeks87
force-pushed
the
click-away-wrapper
branch
from
18220fa to
9f56b2a
Compare
DipperTheDan
previously approved these changes
Jun 6, 2022
Parsium
previously approved these changes
Jun 6, 2022
…directory Adds `ClikcAwayWrapper` component to handle triggering an action if a mousedown event is detected outside of it
edleeks87
force-pushed
the
click-away-wrapper
branch
from
9f56b2a to
3b09573
Compare
DipperTheDan
approved these changes
Jun 10, 2022
Parsium
approved these changes
Jun 10, 2022
DlgSHi
approved these changes
Jun 13, 2022
|
🎉 This PR is included in version 107.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Adds
ClickAwayWrappercomponent to handle triggering an action if a mousedown/ click event is detectedoutside of it
Adds the
ClickAwayWrapperto enable thePopoverContainerto close when amousedownevent isdetected from outside of the wrapper boundaries
Adds
ClickAwayWrappertoDateandSubmenuas wellfix #5017, fix #5158
Current behaviour
No
ClickAwayWrappercomponent exists.PopoverContainerdoes not close when click is outside of it.DateandSubmenuhave their own implementations to handle closing when click outside occursChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
Test Date, Submenu and PopoverContainer stories, clicking inside should not close the components but clicking outside should
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].https://codesandbox.io/s/mystifying-northcutt-c3slyx?file=/src/index.js