fix(tags): update TagProps interface so only the data tag types are exported #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d46234:
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
edleeks87
force-pushed
the
FE-5407-update-tag-props-interface
branch
from
5f8f493 to
3102fd0
Compare
robinzigmond
previously approved these changes
Oct 14, 2022
Parsium
previously approved these changes
Oct 14, 2022
edleeks87
force-pushed
the
FE-5407-update-tag-props-interface
branch
from
3102fd0 to
9a0ece5
Compare
robinzigmond
previously approved these changes
Oct 17, 2022
Parsium
previously approved these changes
Oct 18, 2022
edleeks87
force-pushed
the
FE-5407-update-tag-props-interface
branch
from
9e5784c to
0c8a63a
Compare
Parsium
previously approved these changes
Oct 18, 2022
robinzigmond
previously approved these changes
Oct 18, 2022
DlgSHi
previously approved these changes
Oct 19, 2022
…xported Updates the `TagProps` interface to ensure only the `data-` props are exported and extended in the public interfaces. A new private `RestProps` interface has been added to support passing the rest props object into the `tags` util. The previous implementation was preventing `intellisense` from displaying the correct types for the `Sidebar` component; instead it was being assigned `any`. fix #5534
edleeks87
dismissed stale reviews from DlgSHi, robinzigmond, and Parsium
via
e6d14ba
edleeks87
force-pushed
the
FE-5407-update-tag-props-interface
branch
from
0c8a63a to
e6d14ba
Compare
robinzigmond
approved these changes
Oct 19, 2022
DlgSHi
approved these changes
Oct 19, 2022
|
🎉 This PR is included in version 111.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5534
Proposed behaviour
Updates the
TagPropsinterface to ensure only thedata-props are exported and extended in the public interfaces. A new privateRestPropsinterface has been added to support passing the rest props object into thetagsutil. The previous implementation was preventingintellisensefrom displaying the correct types for theSidebarcomponent; instead it was being assignedany.Current behaviour
The
TagPropsinterface supports any type via[restKeys: string] anywhich prevents intellisense from computing the types of components and instead displayinganyChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].