fix(date): add missing ref TS type (FE-5742) #5942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #15688 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
grabkowski
force-pushed
the
FE-5724-date-add-ref-type
branch
from
fcb3e1a to
d27984b
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c4cd3be:
|
nineteen88
approved these changes
Mar 29, 2023
tomdavies73
approved these changes
Mar 29, 2023
ZhuoyuJin
approved these changes
Mar 31, 2023
|
🎉 This PR is included in version 117.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
add missing type
Current behaviour
ref type is missing on Date component
Checklist
- [ ] Screenshots are included in the PR if useful- [ ] All themes are supported if required- [ ] Unit tests added or updated if required- [ ] Cypress automation tests added or updated if required- [ ] Storybook added or updated if required- [ ] Translations added or updated (including creating or amending translation keys table in storybook) if requiredd.tsfile added or updated if required- [ ] Related docs have been updated if requiredQA
Additional context
fixes #5929
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].