test(button): typescript refactor #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b980489:
|
Passing run #16881 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
DlgSHi
suggested changes
Jul 10, 2023
| ); | ||
|
|
||
| if (booleanState === true) { | ||
| buttonDataComponent() | ||
| .children() | ||
| .children() | ||
| .should("have.value", cssValue, "wrap"); | ||
| .should("have.css", "text-wrap", cssValue); |
There was a problem hiding this comment.
same values in if and else blocks :)
stephenogorman
force-pushed
the
cypress_typescript_button
branch
from
26a8624 to
0cec508
Compare
DlgSHi
approved these changes
Jul 11, 2023
stephenogorman
force-pushed
the
cypress_typescript_button
branch
from
9f348f4 to
b980489
Compare
divyajindel
approved these changes
Jul 11, 2023
|
🎉 This PR is included in version 119.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
button.cy.jstobutton.cy.tsxfile in./cypress/components/button/folder.Current behaviour
Buttontests are in js not ts.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
npx cypress open --componentto check if thebutton.cy.tsxfile passednpx cypress run --componentto check none of the other*.cy.tsxfiles have regressed