-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flat-table, flat-table-row): components can now be wrapped, subRows no longer need to be arrays FE-6050 #6220
Conversation
Passing run #17051 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
6db3883
to
2467ba4
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea27a57:
|
2467ba4
to
bbb9d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments submitted at halfway point to avoid losing them overnight - will complete the review tomorrow
EDIT: now complete
src/components/flat-table/flat-table-header/flat-table-header.component.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row-header/flat-table-row-header.component.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row-header/flat-table-row-header.spec.tsx
Show resolved
Hide resolved
src/components/flat-table/flat-table-row/__internal__/flat-table-row-draggable.component.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row/flat-table-row.component.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row/flat-table-row.spec.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row/flat-table-row.component.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row/flat-table-row.component.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row/flat-table-row.component.tsx
Outdated
Show resolved
Hide resolved
0bccd01
to
8640053
Compare
src/components/flat-table/flat-table-header/flat-table-header.spec.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row-header/flat-table-row-header.component.tsx
Outdated
Show resolved
Hide resolved
src/components/flat-table/flat-table-row/flat-table-row.component.tsx
Outdated
Show resolved
Hide resolved
8640053
to
4dfc828
Compare
4dfc828
to
475ff62
Compare
…ows no longer need to be arrays Refactors `FlatTable` and sub-components to allow consumers greater flexibility with respect to wrapping the components by removing code that relied on iterating over children and cloning. Refactors `FlatTableRow` so that it is no longer required that an array is passed to the `subRows` prop. fix #6219
ea27a57
475ff62
to
ea27a57
Compare
🎉 This PR is included in version 120.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fix #6219
Proposed behaviour
Adds data tags to FlatTableCheckbox
Refactors
FlatTable
and sub-components to allow consumers greater flexibility with respect towrapping the components by removing code that relied on iterating over children and cloning.
Refactors
FlatTableRow
so that it is no longer required that an array is passed to thesubRows
prop. Adds
FlatTableRowContext
andSubRowProvider
as well as addingdata-sticky-align
attribute toFlatTableRowHeader
andid
attribute to all row children to supportexpandable
andsticky
column functionality.Current behaviour
Components rely heavily on children iteration and using cloning to pass props down to achieve desired functionality.
Checklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot]
.https://codesandbox.io/s/romantic-kilby-mhhzsp?file=/src/App.js
https://codesandbox.io/s/table-forked-lq389j?file=/src/Table.js -- children mutation