test(accordion): migrate component tests to playwright #6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinzigmond
force-pushed
the
FE-6091-accordion-playwright
branch
from
2ba588a to
e2781af
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4e64dbe:
|
|
|
||
| ([ | ||
| ["white", "rgb(255, 255, 255)", "be.visible"], | ||
| ["transparent", "rgba(0, 0, 0, 0)", "be.visible"], |
There was a problem hiding this comment.
Should third parameter "be.visible" be here?
There was a problem hiding this comment.
good spot, thanks. Looks like I forgot to remove this from the Cypress test even though we're not using it.
ZhuoyuJin
reviewed
Aug 21, 2023
| page, | ||
| }) => { | ||
| await mount(<AccordionComponent />, { | ||
| hooksConfig: { focusRedesignOptOut: true }, |
There was a problem hiding this comment.
Should we import HooksConfig from playwright and use it here like: "await mount("
ZhuoyuJin
reviewed
Aug 21, 2023
| mount, | ||
| page, | ||
| }) => { | ||
| await mount(<AccordionGroupComponent />, { |
ZhuoyuJin
reviewed
Aug 21, 2023
| page, | ||
| }) => { | ||
| await mount(<AccordionGroupComponent />, { | ||
| hooksConfig: { focusRedesignOptOut: true }, |
ZhuoyuJin
reviewed
Aug 21, 2023
| page, | ||
| }) => { | ||
| await mount(<AccordionGroupComponent />, { | ||
| hooksConfig: { focusRedesignOptOut: true }, |
|
Nothing further to add |
nineteen88
previously approved these changes
Aug 22, 2023
robinzigmond
force-pushed
the
FE-6091-accordion-playwright
branch
from
e2781af to
4e64dbe
Compare
stephenogorman
approved these changes
Aug 22, 2023
ZhuoyuJin
approved these changes
Aug 22, 2023
nineteen88
approved these changes
Aug 22, 2023
|
🎉 This PR is included in version 119.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
The Accordion component should have in-browser tests using the Playwright framework
Current behaviour
Accordion currently has Cypress tests instead of Playwright tests
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].