fix(toast): margin-top on notice variant prevents elements being clicked #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The margin-top on a "notice" Toast would prevent elements behind it from being clicked. fix #6730
nineteen88
approved these changes
May 16, 2024
| @@ -227,7 +227,7 @@ describe("Toast component", () => { | |||
| expect(screen.getByTestId("toast")).toHaveAttribute("id", "exampleId"); | |||
| }); | |||
|
|
|||
| it("shoud render any child content passed via the `children` prop", () => { | |||
| @@ -79,7 +79,19 @@ Default.args = { | |||
| }; | |||
| Default.argTypes = { | |||
| variant: { | |||
| options: TOAST_COLORS, | |||
There was a problem hiding this comment.
praise: nice improvement to add the missing props
DipperTheDan
approved these changes
May 16, 2024
stephenogorman
approved these changes
May 17, 2024
|
🎉 This PR is included in version 135.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6730
Proposed behaviour
Remove margin-top from "notice"
Toast.Current behaviour
The margin-top on a "notice"
Toastprevents elements behind it from being clicked.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions